Skip to content

Consent screen update #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 21, 2019
Merged

Consent screen update #41

merged 4 commits into from
May 21, 2019

Conversation

jaxoncreed
Copy link
Contributor

@jaxoncreed jaxoncreed mentioned this pull request May 18, 2019
Merged
@kjetilk kjetilk requested a review from dmitrizagidulin May 20, 2019 08:41
dmitrizagidulin
dmitrizagidulin approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@dmitrizagidulin dmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me. (Although I'm curious - why the preference for Object.assign() instead of the ... spread operator?)

@michielbdejong
Copy link
Member

It was because we want to support Node 8, see 273c693

@jaxoncreed jaxoncreed merged commit a8f8945 into master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michielbdejong michielbdejong michielbdejong approved these changes

@dmitrizagidulin dmitrizagidulin dmitrizagidulin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaxoncreed @michielbdejong @dmitrizagidulin