Skip to content

Adding script clean and adding it to solid script#854

Merged
kjetilk merged 2 commits intodevelopfrom
feature/clean-script
Oct 10, 2018
Merged

Adding script clean and adding it to solid script#854
kjetilk merged 2 commits intodevelopfrom
feature/clean-script

Conversation

@megoth
Copy link
Contributor

@megoth megoth commented Oct 10, 2018

For my own sanity - I keep forgetting to remove config files if I want to get updates from default-templates and default-views.

Ignore this if it's to invasive

For my own sanity - I keep forgetting to remove config files if I want to get updates from default-templates and default-views.

Ignore this if people feel it's to invasive
@dmitrizagidulin
Copy link
Contributor

@megoth the script looks good. My only question is - does it make sense to have the clean script automatically run whenever you launch the server? (Not that I expect a lot of people use the npm run solid script instead of launching it directly via node).

@kjetilk
Copy link
Member

kjetilk commented Oct 10, 2018

Yeah, that was my question too, perhaps only do it if launched explicitly?

@dmitrizagidulin
Copy link
Contributor

I think what I'm trying to say is - maybe it's just enough to add a clean script. so that testers and devs can explicitly launch with npm run clean && npm run solid? Without hitching it to the run script?

@megoth
Copy link
Contributor Author

megoth commented Oct 10, 2018

Yeah, I'm ok with it not being part of the solid-script; it was merely a convenience for my own sake ^_^ I'll update the PR very soon

@megoth
Copy link
Contributor Author

megoth commented Oct 10, 2018

@kjetilk @dmitrizagidulin I've updated the PR ^_^

Copy link
Contributor

@dmitrizagidulin dmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kjetilk kjetilk merged commit f276c57 into develop Oct 10, 2018
@dmitrizagidulin dmitrizagidulin deleted the feature/clean-script branch October 11, 2018 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants