Skip to content

improve consistency of the look and feel of the two buttons#1763

Merged
bourgeoa merged 3 commits intonodeSolidServer:mainfrom
ewingson:main
Apr 22, 2024
Merged

improve consistency of the look and feel of the two buttons#1763
bourgeoa merged 3 commits intonodeSolidServer:mainfrom
ewingson:main

Conversation

@ewingson
Copy link
Contributor

@ewingson ewingson commented Mar 5, 2024

d2024-03-05 t08:22

@bourgeoa the two buttons look different in the moment in size.
this PR improves the UI via making the size the same and consistent.

@ewingson
Copy link
Contributor Author

ewingson commented Mar 6, 2024

update after code correction:
I'm not sure why the tests fail, the code is exactly as deployed to https://solidweb.org where you can see a working example the buttons look the same now.
would someone with experience take care / feel responsible ?
additional : maybe line 41 should become commented out ?

Copy link
Contributor

@zg009 zg009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good improvement to me.

@bourgeoa bourgeoa merged commit 60ef3aa into nodeSolidServer:main Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants