Skip to content

Social: pushover; add callback parameter w/ documentation #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2021

Conversation

brianmangan
Copy link
Contributor

  • Bugfix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)

Proposed changes

Pushover offers a callback feature where a user can pass a url.
I have added the required variables, parameters and documentation. This value is only passed by msg.callback.

Checklist

  • [ x] I have read the contribution guidelines
  • [ x] For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • [ x] I have run grunt to verify the unit tests pass
  • [ n/a] I have added suitable unit tests to cover the new/changed functionality

@brianmangan brianmangan changed the title Social pushover documentation Social pushover: add callback parameter w/ documentation Aug 27, 2021
@brianmangan brianmangan changed the title Social pushover: add callback parameter w/ documentation Social: pushover; add callback parameter w/ documentation Aug 27, 2021
@dceejay
Copy link
Member

dceejay commented Aug 28, 2021

looks good - you happy with it now ?

@brianmangan
Copy link
Contributor Author

I am happy with it now, thank you!

@dceejay dceejay merged commit 6ca7097 into node-red:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants