Skip to content

Fix async module loading #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knolleary merged 1 commit into from
Jun 23, 2023
Merged

Fix async module loading #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
#### 0.3.2

- Fix async module loading @knolleary


#### 0.3.1

- Add support for async node modules (#63) @knolleary
Expand Down
8 changes: 3 additions & 5 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,6 @@ class NodeTestHelper extends EventEmitter {
library: {register: function() {}},
get server() { return self._server }
}

redNodes.init(mockRuntime);
redNodes.registerType("helper", function (n) {
redNodes.createNode(this, n);
Expand Down Expand Up @@ -281,10 +280,9 @@ class NodeTestHelper extends EventEmitter {
}
}
});

return Promise.all(initPromises)
.then(redNodes.loadFlows)
.then(redNodes.startFlows)
.then(() => redNodes.loadFlows())
.then(() => redNodes.startFlows())
.then(() => {
should.deepEqual(testFlow, redNodes.getFlows().flows);
if(cb) cb();
Expand All @@ -299,7 +297,7 @@ class NodeTestHelper extends EventEmitter {

// internal API
this._context.clean({allNodes:[]});
return this._redNodes.stopFlows();
return this._redNodes.stopFlows()
}

/**
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "node-red-node-test-helper",
"version": "0.3.1",
"version": "0.3.2",
"description": "A test framework for Node-RED nodes",
"main": "index.js",
"scripts": {
Expand Down