Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to use helper with async/await style programming #28

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

myplacedk
Copy link

To do based on comments from here:

  • Change code style / commit style
  • Documentation. I documented the API and added example files. I feel like duplicating all relevant examples in the README with async versions is too noisy. Maybe all that needs is one or two references to the new example files, to make it more discoverable.
  • Any other tasks. I'm just dipping my toes into Node Red, feedback is very welcome.

@jsf-clabot
Copy link

jsf-clabot commented Nov 19, 2018

CLA assistant check
All committers have signed the CLA.

@myplacedk
Copy link
Author

The CLA is now signed.

@myplacedk
Copy link
Author

I used the wrong email address in the commits, sorry. I amended all the commits and force-pushed.

@JbIPS
Copy link
Contributor

JbIPS commented Jun 9, 2021

Woah thank you @myplacedk, I was trying to achieve the same thing!

I know it's a bit old, but is it still valid? @knolleary, is it mergeable? I can take care of the conflicts if necessary

@amir-arad
Copy link

@myplacedk Thank you! I hope this will be merged soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants