Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: ApplyFlagsForEthConfig to handle different pruning modes based on chainId #507

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

du5
Copy link

@du5 du5 commented Sep 17, 2024

No description provided.

@blxdyx
Copy link
Collaborator

blxdyx commented Sep 18, 2024

There have PruneDistanceFlag and PruneBlocksDistanceFlag, so i think we don't need this.

PruneDistanceFlag = cli.Uint64Flag{
Name: "prune.distance",
Usage: `Keep state history for the latest N blocks (default: everything)`,
}
PruneBlocksDistanceFlag = cli.Uint64Flag{
Name: "prune.distance.blocks",
Usage: `Keep block history for the latest N blocks (default: everything)`,
}

@du5
Copy link
Author

du5 commented Sep 18, 2024

There have PruneDistanceFlag and PruneBlocksDistanceFlag, so i think we don't need this.

PruneDistanceFlag = cli.Uint64Flag{

I think this can reduce the length of the startup parameters. This modification can make --prune.mode=minimal --chain=bsc equivalent to --prune.mode=archive --prune.distance.blocks=90000 --prune.distance=90000 --chain=bsc

@setunapo setunapo merged commit ba95a69 into node-real:erigon3 Sep 18, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants