Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bohr #452

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Bohr #452

merged 4 commits into from
Jul 25, 2024

Conversation

MatusKysel
Copy link
Collaborator

No description provided.

@blxdyx
Copy link
Collaborator

blxdyx commented Jul 24, 2024

@blxdyx
Copy link
Collaborator

blxdyx commented Jul 24, 2024

Seem getFinalizeBlock also need change

@MatusKysel
Copy link
Collaborator Author

https://github.com/node-real/bsc-erigon/blob/main/core/genesis_write.go#L594 https://github.com/node-real/bsc-erigon/blob/main/consensus/parlia/util.go#L21 Need add change here?

can you be more specific about genesis change? I do not think I understand

@MatusKysel
Copy link
Collaborator Author

Seem getFinalizeBlock also need change

we are using finalized block based on that https://github.com/node-real/bsc-erigon/blob/bohr/consensus/parlia/parlia.go#L1132 so I think we should be ok as snapshot as correct value, right?

@MatusKysel MatusKysel marked this pull request as ready for review July 24, 2024 12:08
@blxdyx blxdyx merged commit 214ac14 into main Jul 25, 2024
5 of 7 checks passed
@MatusKysel MatusKysel deleted the bohr branch July 25, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants