Skip to content

DICOM Viewer #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

DICOM Viewer #13

wants to merge 2 commits into from

Conversation

@awatson1978
Copy link
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 9, 2025
View reviewed changes
packages/dicom-viewer/lib/JpgToDicomService.js
// Create DICOM header with proper tags
createDicomHeader(imageData, metadata = {}) {
const now = moment();
const studyUID = this.generateUID();

Check failure

Code scanning / CodeQL

Insecure randomness High

This uses a cryptographically insecure random number generated at
Math.random()
Loading
in a security context.

Copilot Autofix

AI 4 months ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

packages/dicom-viewer/lib/JpgToDicomService.js
createDicomHeader(imageData, metadata = {}) {
const now = moment();
const studyUID = this.generateUID();
const seriesUID = this.generateUID();

Check failure

Code scanning / CodeQL

Insecure randomness High

This uses a cryptographically insecure random number generated at
Math.random()
Loading
in a security context.

Copilot Autofix

AI 4 months ago

To fix the issue, we need to replace the use of Math.random() with a cryptographically secure random number generator. In Node.js, the crypto module provides a secure method for generating random bytes. We can use crypto.randomBytes to generate a secure random number and ensure that the UIDs are unpredictable.

The generateUID method will be updated to use crypto.randomBytes to generate a random component. The random bytes will be converted to a hexadecimal string to ensure compatibility with the UID format.

Suggested changeset 1
packages/dicom-viewer/lib/JpgToDicomService.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/packages/dicom-viewer/lib/JpgToDicomService.js b/packages/dicom-viewer/lib/JpgToDicomService.js
--- a/packages/dicom-viewer/lib/JpgToDicomService.js
+++ b/packages/dicom-viewer/lib/JpgToDicomService.js
@@ -2,2 +2,3 @@
 import { get } from 'lodash';
+import crypto from 'crypto';
 import moment from 'moment';
@@ -14,3 +15,3 @@
     const timestamp = Date.now();
-    const random = Math.floor(Math.random() * 1000000);
+    const random = crypto.randomBytes(6).toString('hex'); // Generate 6 random bytes and convert to hex
     return `${prefix}${timestamp}.${random}`;
EOF
@@ -2,2 +2,3 @@
import { get } from 'lodash';
import crypto from 'crypto';
import moment from 'moment';
@@ -14,3 +15,3 @@
const timestamp = Date.now();
const random = Math.floor(Math.random() * 1000000);
const random = crypto.randomBytes(6).toString('hex'); // Generate 6 random bytes and convert to hex
return `${prefix}${timestamp}.${random}`;
Copilot is powered by AI and may make mistakes. Always verify output.
packages/dicom-viewer/lib/JpgToDicomService.js
const now = moment();
const studyUID = this.generateUID();
const seriesUID = this.generateUID();
const instanceUID = this.generateUID();

Check failure

Code scanning / CodeQL

Insecure randomness High

This uses a cryptographically insecure random number generated at
Math.random()
Loading
in a security context.

Copilot Autofix

AI 4 months ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

packages/dicom-viewer/server/file-processor.js

return {
// Study level
studyInstanceUID: generateUID(),

Check failure

Code scanning / CodeQL

Insecure randomness High

This uses a cryptographically insecure random number generated at
Math.random()
Loading
in a security context.

Copilot Autofix

AI 4 months ago

To fix the issue, we will replace the use of Math.random() in the generateUID() function with a cryptographically secure random number generator. In Node.js, the crypto module provides a secure way to generate random values. Specifically, we will use crypto.randomBytes() to generate a random number. This ensures that the generated UIDs are unpredictable and secure.

The changes will involve:

  1. Importing the crypto module at the top of the file.
  2. Modifying the generateUID() function to use crypto.randomBytes() instead of Math.random().
Suggested changeset 1
packages/dicom-viewer/server/file-processor.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/packages/dicom-viewer/server/file-processor.js b/packages/dicom-viewer/server/file-processor.js
--- a/packages/dicom-viewer/server/file-processor.js
+++ b/packages/dicom-viewer/server/file-processor.js
@@ -3,2 +3,3 @@
 import { Studies, Series, Instances } from '../lib/collections';
+import crypto from 'crypto';
 
@@ -265,3 +266,3 @@
   const timestamp = Date.now();
-  const random = Math.floor(Math.random() * 100000);
+  const random = parseInt(crypto.randomBytes(4).toString('hex'), 16);
   return `${prefix}.${timestamp}.${random}`;
EOF
@@ -3,2 +3,3 @@
import { Studies, Series, Instances } from '../lib/collections';
import crypto from 'crypto';

@@ -265,3 +266,3 @@
const timestamp = Date.now();
const random = Math.floor(Math.random() * 100000);
const random = parseInt(crypto.randomBytes(4).toString('hex'), 16);
return `${prefix}.${timestamp}.${random}`;
Copilot is powered by AI and may make mistakes. Always verify output.
packages/dicom-viewer/server/file-processor.js
studyDescription: 'Test Study',

// Series level
seriesInstanceUID: generateUID(),

Check failure

Code scanning / CodeQL

Insecure randomness High

This uses a cryptographically insecure random number generated at
Math.random()
Loading
in a security context.

Copilot Autofix

AI 4 months ago

To fix the issue, replace the use of Math.random() with a cryptographically secure random number generator. In Node.js, the crypto module provides a secure method for generating random bytes. Specifically, crypto.randomBytes can be used to generate random values securely. The fix involves modifying the generateUID() function to use crypto.randomBytes for generating the random component of the UID.

Steps to implement the fix:

  1. Import the crypto module at the top of the file.
  2. Replace the Math.random() logic in generateUID() with crypto.randomBytes to generate a secure random number.
  3. Ensure the generated random number is formatted appropriately for inclusion in the UID.
Suggested changeset 1
packages/dicom-viewer/server/file-processor.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/packages/dicom-viewer/server/file-processor.js b/packages/dicom-viewer/server/file-processor.js
--- a/packages/dicom-viewer/server/file-processor.js
+++ b/packages/dicom-viewer/server/file-processor.js
@@ -1,2 +1,3 @@
 import { Meteor } from 'meteor/meteor';
+import crypto from 'crypto';
 import { get } from 'lodash';
@@ -265,3 +266,4 @@
   const timestamp = Date.now();
-  const random = Math.floor(Math.random() * 100000);
+  const randomBytes = crypto.randomBytes(4); // Generate 4 random bytes
+  const random = parseInt(randomBytes.toString('hex'), 16); // Convert to a large integer
   return `${prefix}.${timestamp}.${random}`;
EOF
@@ -1,2 +1,3 @@
import { Meteor } from 'meteor/meteor';
import crypto from 'crypto';
import { get } from 'lodash';
@@ -265,3 +266,4 @@
const timestamp = Date.now();
const random = Math.floor(Math.random() * 100000);
const randomBytes = crypto.randomBytes(4); // Generate 4 random bytes
const random = parseInt(randomBytes.toString('hex'), 16); // Convert to a large integer
return `${prefix}.${timestamp}.${random}`;
Copilot is powered by AI and may make mistakes. Always verify output.
packages/dicom-viewer/server/file-processor.js
seriesDescription: 'Test Series',

// Instance level
sopInstanceUID: generateUID(),

Check failure

Code scanning / CodeQL

Insecure randomness High

This uses a cryptographically insecure random number generated at
Math.random()
Loading
in a security context.

Copilot Autofix

AI 4 months ago

To fix the issue, replace the use of Math.random() with a cryptographically secure random number generator. In Node.js, the crypto module provides a secure method for generating random values. Specifically, crypto.randomBytes can be used to generate random bytes, which can then be converted into a number or string as needed.

The generateUID() function should be updated to use crypto.randomBytes to generate the random component of the UID. This ensures that the generated UIDs are unpredictable and secure. The changes will involve importing the crypto module and modifying the generateUID() function.

Suggested changeset 1
packages/dicom-viewer/server/file-processor.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/packages/dicom-viewer/server/file-processor.js b/packages/dicom-viewer/server/file-processor.js
--- a/packages/dicom-viewer/server/file-processor.js
+++ b/packages/dicom-viewer/server/file-processor.js
@@ -1,2 +1,3 @@
 import { Meteor } from 'meteor/meteor';
+import crypto from 'crypto';
 import { get } from 'lodash';
@@ -265,3 +266,4 @@
   const timestamp = Date.now();
-  const random = Math.floor(Math.random() * 100000);
+  const randomBytes = crypto.randomBytes(6); // Generate 6 random bytes
+  const random = parseInt(randomBytes.toString('hex'), 16); // Convert to a large random number
   return `${prefix}.${timestamp}.${random}`;
EOF
@@ -1,2 +1,3 @@
import { Meteor } from 'meteor/meteor';
import crypto from 'crypto';
import { get } from 'lodash';
@@ -265,3 +266,4 @@
const timestamp = Date.now();
const random = Math.floor(Math.random() * 100000);
const randomBytes = crypto.randomBytes(6); // Generate 6 random bytes
const random = parseInt(randomBytes.toString('hex'), 16); // Convert to a large random number
return `${prefix}.${timestamp}.${random}`;
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@awatson1978