fix: ensure values are strings when passed to the functions#3
Merged
jankapunkt merged 6 commits intomainfrom Jan 26, 2026
Merged
fix: ensure values are strings when passed to the functions#3jankapunkt merged 6 commits intomainfrom
jankapunkt merged 6 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens the format validators so they only accept string inputs and adds tests to ensure non-string values are rejected, along with updating the npm lockfile to the v3 format.
Changes:
- Introduced a shared
ensureStringhelper inindex.jsand wired it into all exportedisFormatvalidators to throw aTypeErroron non-string inputs. - Added
ensureValidFormattests intest/formats.test.jsto assert that each validator throws aTypeErrorwith a consistent message when called with invalid types. - Regenerated
package-lock.jsonto lockfileVersion 3 with explicitpackagesmetadata, aligning with the currentpackage.jsondevDependencies.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| index.js | Adds ensureString and applies it to nchar, nqchar, nqschar, uchar, uri, and vschar to enforce string-only inputs. |
| test/formats.test.js | Adds ensureValidFormat helper and invokes it in each test to check type validation behavior, while still exercising the existing range-based format checks. |
| package-lock.json | Updates npm lockfile to version 3 and reflects the current devDependency graph for tooling (chai, mocha, eslint, nyc, jsdoc-to-markdown, etc.). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing tests I found the following problem:
This means that the OAuth test suite currently does not cover if values are not strings.
This PR fixes that by prepending a check for string type in every function.
After that we need to update OAuth2 server tests accordingly!