4.0.0 - Migrate to async/await #22

jankapunkt · 2024-01-03T22:53:38Z

Might be breaking for older setups!

bump minimal node to 16
upgrade @node-oauth/oauth2-server to 5.1.0
drop bluebird dependency
upgrade all deps / dev-deps
refactor all code to minimum es6
use native async/await
update ci to use minimum node 16
update readme and changelog
make express peer depdendency with * value so there will always be the express version used that is installed by users
test coverage to 100%

index.js

…hensive jsDoc comments

test/integration/index_test.js

+    it('should return an error if `model` is empty', function(done) {
+      const oauth = new ExpressOAuthServer({ model: {} });
+
+      app.use(oauth.authorize());


test/integration/index_test.js

+        }
+      };
+      const oauth = new ExpressOAuthServer({ model });
+      app.use(oauth.authenticate());


jankapunkt · 2024-01-04T09:31:18Z

@jorenvandeweyer please note that express is now a peer dependency, since there will soon be a major transition to express 5 while many ppl will still run on express 4 and from what I see this peer dependency is a good way to avoid major version conflicts by always pointing to the user's express installation. On the tests we use latest express 4 rn, though

jankapunkt · 2024-01-08T12:35:56Z

@jorenvandeweyer resolved the issues, can you please review, again?

docs/scripts/prettify/lang-css.js

@@ -0,0 +1,2 @@
+PR.registerLangHandler(PR.createSimpleLexer([["pln",/^[\t\n\f\r ]+/,null," \t\r\n"]],[["str",/^"(?:[^\n\f\r"\\]|\\(?:\r\n?|\n|\f)|\\[\S\s])*"/,null],["str",/^'(?:[^\n\f\r'\\]|\\(?:\r\n?|\n|\f)|\\[\S\s])*'/,null],["lang-css-str",/^url\(([^"')]*)\)/i],["kwd",/^(?:url|rgb|!important|@import|@page|@media|@charset|inherit)(?=[^\w-]|$)/i,null],["lang-css-kw",/^(-?(?:[_a-z]|\\[\da-f]+ ?)(?:[\w-]|\\\\[\da-f]+ ?)*)\s*:/i],["com",/^\/\*[^*]*\*+(?:[^*/][^*]*\*+)*\//],["com",


docs/scripts/prettify/lang-css.js

@@ -0,0 +1,2 @@
+PR.registerLangHandler(PR.createSimpleLexer([["pln",/^[\t\n\f\r ]+/,null," \t\r\n"]],[["str",/^"(?:[^\n\f\r"\\]|\\(?:\r\n?|\n|\f)|\\[\S\s])*"/,null],["str",/^'(?:[^\n\f\r'\\]|\\(?:\r\n?|\n|\f)|\\[\S\s])*'/,null],["lang-css-str",/^url\(([^"')]*)\)/i],["kwd",/^(?:url|rgb|!important|@import|@page|@media|@charset|inherit)(?=[^\w-]|$)/i,null],["lang-css-kw",/^(-?(?:[_a-z]|\\[\da-f]+ ?)(?:[\w-]|\\\\[\da-f]+ ?)*)\s*:/i],["com",/^\/\*[^*]*\*+(?:[^*/][^*]*\*+)*\//],["com",


docs/scripts/prettify/lang-css.js

@@ -0,0 +1,2 @@
+PR.registerLangHandler(PR.createSimpleLexer([["pln",/^[\t\n\f\r ]+/,null," \t\r\n"]],[["str",/^"(?:[^\n\f\r"\\]|\\(?:\r\n?|\n|\f)|\\[\S\s])*"/,null],["str",/^'(?:[^\n\f\r'\\]|\\(?:\r\n?|\n|\f)|\\[\S\s])*'/,null],["lang-css-str",/^url\(([^"')]*)\)/i],["kwd",/^(?:url|rgb|!important|@import|@page|@media|@charset|inherit)(?=[^\w-]|$)/i,null],["lang-css-kw",/^(-?(?:[_a-z]|\\[\da-f]+ ?)(?:[\w-]|\\\\[\da-f]+ ?)*)\s*:/i],["com",/^\/\*[^*]*\*+(?:[^*/][^*]*\*+)*\//],["com",


docs/scripts/prettify/lang-css.js

@@ -0,0 +1,2 @@
+PR.registerLangHandler(PR.createSimpleLexer([["pln",/^[\t\n\f\r ]+/,null," \t\r\n"]],[["str",/^"(?:[^\n\f\r"\\]|\\(?:\r\n?|\n|\f)|\\[\S\s])*"/,null],["str",/^'(?:[^\n\f\r'\\]|\\(?:\r\n?|\n|\f)|\\[\S\s])*'/,null],["lang-css-str",/^url\(([^"')]*)\)/i],["kwd",/^(?:url|rgb|!important|@import|@page|@media|@charset|inherit)(?=[^\w-]|$)/i,null],["lang-css-kw",/^(-?(?:[_a-z]|\\[\da-f]+ ?)(?:[\w-]|\\\\[\da-f]+ ?)*)\s*:/i],["com",/^\/\*[^*]*\*+(?:[^*/][^*]*\*+)*\//],["com",
+/^(?:<\!--|--\>)/],["lit",/^(?:\d+|\d*\.\d+)(?:%|[a-z]+)?/i],["lit",/^#[\da-f]{3,6}/i],["pln",/^-?(?:[_a-z]|\\[\da-f]+ ?)(?:[\w-]|\\\\[\da-f]+ ?)*/i],["pun",/^[^\s\w"']+/]]),["css"]);PR.registerLangHandler(PR.createSimpleLexer([],[["kwd",/^-?(?:[_a-z]|\\[\da-f]+ ?)(?:[\w-]|\\\\[\da-f]+ ?)*/i]]),["css-kw"]);PR.registerLangHandler(PR.createSimpleLexer([],[["str",/^[^"')]+/]]),["css-str"]);


jankapunkt · 2024-01-09T08:17:29Z

Published @node-oauth/express-oauth-server@4.0.0-rc.0

jankapunkt added 10 commits January 1, 2024 21:10

tests: update location header

b7fbc11

tests: rewrite tests to es6

ab7d763

refactor: rewrite to use native async/await

fd38098

build(deps): update deps to latest, drop bluebird

0168c66

build(core): bump minimal node to 16

9a90004

ci: update node versions to minimum 16

6b782da

docs: updated for next release

7eee7b0

build(core): prepare 4.0.0-rc.0 release

7eb7b66

Merge branch 'master' of github.com:node-oauth/express-oauth-server

1390685

Merge branch 'master' into migrate-es-6

1b88ef0

jankapunkt requested review from HappyZombies, dhensby and jorenvandeweyer January 3, 2024 22:55

jankapunkt changed the title ~~Migrate es 6~~ 4.0.0 - Migrate to async/await Jan 3, 2024

jorenvandeweyer requested changes Jan 4, 2024

View reviewed changes

index.js Outdated Show resolved Hide resolved

jankapunkt added 4 commits January 4, 2024 10:26

tests: coverage 100%

32d13c0

refactor: move remaining functions into es6 class and add more compre…

67ae088

…hensive jsDoc comments

docs: link OAuth2 server documentation to options section in README

ad43b57

build(core): make express a peer dependency to avoid version conflicts

10d56f8

github-advanced-security bot found potential problems Jan 4, 2024

View reviewed changes

jankapunkt requested a review from jorenvandeweyer January 4, 2024 09:29

kanelloc mentioned this pull request Jan 8, 2024

Errors problems with @node-oauth/express-oauth-server and @node-oauth/oauth2-server version 5 #23

Closed

jankapunkt linked an issue Jan 8, 2024 that may be closed by this pull request

Errors problems with @node-oauth/express-oauth-server and @node-oauth/oauth2-server version 5 #23

Closed

jorenvandeweyer approved these changes Jan 8, 2024

View reviewed changes

jankapunkt added 4 commits January 9, 2024 09:04

refactor: move exxamples to own reppository

8f2646c

docs: add jsDoc-based API documentation

79cbc8a

fix: eslint config; ignore update+fix

9137839

docs: updated

15d6271

ci: added lint and docs build to ci

fe5ec7c

github-advanced-security bot found potential problems Jan 9, 2024

View reviewed changes

jankapunkt linked an issue Jan 9, 2024 that may be closed by this pull request

Remove express as a dependency #13

Closed

This was referenced Jan 27, 2024

How run examples? #21

Closed

Examples are out of date #14

Closed

jankapunkt merged commit deb11f2 into master Feb 5, 2024

dhensby deleted the migrate-es-6 branch February 5, 2024 09:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

4.0.0 - Migrate to async/await #22

4.0.0 - Migrate to async/await #22

Uh oh!

jankapunkt commented Jan 3, 2024 •

edited

Loading

Uh oh!

Uh oh!

Check failure

Check failure

jankapunkt commented Jan 4, 2024

Uh oh!

jankapunkt commented Jan 8, 2024

Uh oh!

Check failure

Check failure

Check failure

Check failure

jankapunkt commented Jan 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,2 @@
		PR.registerLangHandler(PR.createSimpleLexer([["pln",/^[\t\n\f\r ]+/,null," \t\r\n"]],[["str",/^"(?:[^\n\f\r"\\]\|\\(?:\r\n?\|\n\|\f)\|\\[\S\s])"/,null],["str",/^'(?:[^\n\f\r'\\]\|\\(?:\r\n?\|\n\|\f)\|\\[\S\s])'/,null],["lang-css-str",/^url\(([^"')])\)/i],["kwd",/^(?:url\|rgb\|!important\|@import\|@page\|@media\|@charset\|inherit)(?=[^\w-]\|$)/i,null],["lang-css-kw",/^(-?(?:[_a-z]\|\\[\da-f]+ ?)(?:[\w-]\|\\\\[\da-f]+ ?))\s:/i],["com",/^\/\[^]\+(?:[^/][^]\+)\//],["com",

		@@ -0,0 +1,2 @@
		PR.registerLangHandler(PR.createSimpleLexer([["pln",/^[\t\n\f\r ]+/,null," \t\r\n"]],[["str",/^"(?:[^\n\f\r"\\]\|\\(?:\r\n?\|\n\|\f)\|\\[\S\s])"/,null],["str",/^'(?:[^\n\f\r'\\]\|\\(?:\r\n?\|\n\|\f)\|\\[\S\s])'/,null],["lang-css-str",/^url\(([^"')])\)/i],["kwd",/^(?:url\|rgb\|!important\|@import\|@page\|@media\|@charset\|inherit)(?=[^\w-]\|$)/i,null],["lang-css-kw",/^(-?(?:[_a-z]\|\\[\da-f]+ ?)(?:[\w-]\|\\\\[\da-f]+ ?))\s:/i],["com",/^\/\[^]\+(?:[^/][^]\+)\//],["com",
		/^(?:<\!--\|--\>)/],["lit",/^(?:\d+\|\d\.\d+)(?:%\|[a-z]+)?/i],["lit",/^#[\da-f]{3,6}/i],["pln",/^-?(?:[_a-z]\|\\[\da-f]+ ?)(?:[\w-]\|\\\\[\da-f]+ ?)/i],["pun",/^[^\s\w"']+/]]),["css"]);PR.registerLangHandler(PR.createSimpleLexer([],[["kwd",/^-?(?:[_a-z]\|\\[\da-f]+ ?)(?:[\w-]\|\\\\[\da-f]+ ?)*/i]]),["css-kw"]);PR.registerLangHandler(PR.createSimpleLexer([],[["str",/^[^"')]+/]]),["css-str"]);

4.0.0 - Migrate to async/await #22

4.0.0 - Migrate to async/await #22

Uh oh!

Conversation

jankapunkt commented Jan 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Check failure

Check failure

jankapunkt commented Jan 4, 2024

Uh oh!

jankapunkt commented Jan 8, 2024

Uh oh!

Check failure

Check failure

Check failure

Check failure

jankapunkt commented Jan 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jankapunkt commented Jan 3, 2024 •

edited

Loading