Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nan: upgrade nan to 1.5.3 to make v8-profiler compat with io.js #51

Merged
merged 1 commit into from
Jan 23, 2015
Merged

nan: upgrade nan to 1.5.3 to make v8-profiler compat with io.js #51

merged 1 commit into from
Jan 23, 2015

Conversation

thlorenz
Copy link
Contributor

  • adapting creation of ObjectTemplate
  • adapting one NanNew<Integer> which was ambiguous with new version of nan

I verified that this version works with iojs, node 0.10 and node 0.11.
The reason I upgraded nan to 1.5.3 instead of the latest 1.6 for now is that it is not compatible with io.js.
I'm filing a related issue with nan.

Here is the truncated output I got when rebuilding v8-profiler and running tests for different node versions:

➝  nave use 0.11
Already installed: 0.11.15
using 0.11.15

➝  node-gyp rebuild && npm test

21 passing (305ms)

++++++++

➝  nave use 0.10
Already installed: 0.10.35
using 0.10.35

➝  node-gyp rebuild && npm test


21 passing (541ms)

++++++++

➝  ../iojs/iojs --version
v1.0.4

node-gyp rebuild --nodedir ../iojs/ && ../iojs/deps/npm/bin/npm-cli.js test

21 passing (549ms)

In order to run node-gyp rebuild I temporarily changed the binding.gyp file as follows (not part of PR):

diff --git a/binding.gyp b/binding.gyp
index 1f87c9f..5acba86 100644
--- a/binding.gyp
+++ b/binding.gyp
@@ -20,11 +20,11 @@
     {
       "target_name": "action_after_build",
       "type": "none",
-      "dependencies": [ "<(module_name)" ],
+#      "dependencies": [ "<(module_name)" ],
       "copies": [
         {
-          "files": [ "<(PRODUCT_DIR)/<(module_name).node" ],
-          "destination": "<(module_path)"
+          "files": [ "<(PRODUCT_DIR)/profiler.node" ],
+          "destination": "build"
         }
       ]
     }

- adapting creation of `ObjectTemplate`
- adapting one `NanNew<Integer>` which was ambiguous with new version of nan
@3y3
Copy link
Member

3y3 commented Jan 23, 2015

Wow! That's nice, you freed my weekend =)

@3y3 3y3 merged commit 2e21898 into node-inspector:master Jan 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants