nan: upgrade nan to 1.5.3 to make v8-profiler compat with io.js #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectTemplate
NanNew<Integer>
which was ambiguous with new version of nanI verified that this version works with iojs, node 0.10 and node 0.11.
The reason I upgraded nan to
1.5.3
instead of the latest1.6
for now is that it is not compatible with io.js.I'm filing a related issue with nan.
Here is the truncated output I got when rebuilding v8-profiler and running tests for different node versions:
In order to run
node-gyp rebuild
I temporarily changed thebinding.gyp
file as follows (not part of PR):