Skip to content

Add generated typings for from.js file. #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

octet-stream
Copy link
Contributor

@octet-stream octet-stream commented Apr 13, 2021

This pull request brings missing types for Blob backed by fs. It addresses the issue when TS asking to install missing types for fetch-blob/from.js or write corresponding declaration file:

Details

2021-04-14 02 42 44


I also added domexception into devDependencies because tests are failing without it. I think it's fine to have it here rather then install it manually every time you clone the repo and need to run through tests. It also won't be included once you run npm install fetch-blob to install the package. Please, let me know if it has to be reverted for a reason, because I don't really understand why you did that.

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #80 (ead4eb3) into master (eed6a1d) will not change coverage.
The diff coverage is 100.00%.

❗ Current head ead4eb3 differs from pull request most recent head 60187f6. Consider uploading reports for the commit 60187f6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master       #80   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          235       232    -3     
  Branches        37        36    -1     
=========================================
- Hits           235       232    -3     
Impacted Files Coverage Δ
from.js 100.00% <100.00%> (ø)
index.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed6a1d...60187f6. Read the comment docs.

@octet-stream
Copy link
Contributor Author

@jimmywarting @xxczaki can someone review this PR, please?

@jimmywarting
Copy link
Contributor

I also added domexception into devDependencies

that is fine

because I don't really understand why you did that.

Some ppl don't use from so it would be unnecessary to install another dependency if they don't need it

@jimmywarting jimmywarting dismissed their stale review April 20, 2021 14:09

I can fix it

@jimmywarting jimmywarting merged commit f08e6a6 into node-fetch:master Apr 20, 2021
@octet-stream octet-stream deleted the octet-stream/add-from-blob-typings branch April 20, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants