-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct Driver HAL #816
Merged
Merged
Direct Driver HAL #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
force-pushed
the
makslevental/xrt-lite
branch
11 times, most recently
from
October 3, 2024 02:35
9644459
to
8f82b0a
Compare
makslevental
force-pushed
the
makslevental/xrt-lite
branch
19 times, most recently
from
October 12, 2024 00:11
8e0d61a
to
dae35a9
Compare
makslevental
force-pushed
the
makslevental/xrt-lite
branch
from
October 18, 2024 19:50
29941e2
to
022cda3
Compare
makslevental
force-pushed
the
makslevental/xrt-lite
branch
from
October 18, 2024 20:02
022cda3
to
8974d20
Compare
makslevental
commented
Oct 18, 2024
compiler/plugins/target/AMD-AIE/iree-amd-aie/Target/AIETarget.h
Outdated
Show resolved
Hide resolved
makslevental
commented
Oct 18, 2024
compiler/plugins/target/AMD-AIE/iree-amd-aie/Target/AIETarget.cpp
Outdated
Show resolved
Hide resolved
makslevental
commented
Oct 18, 2024
compiler/plugins/target/AMD-AIE/iree-amd-aie/Target/AIETarget.cpp
Outdated
Show resolved
Hide resolved
makslevental
commented
Oct 18, 2024
compiler/plugins/target/AMD-AIE/iree-amd-aie/Target/AIETarget.cpp
Outdated
Show resolved
Hide resolved
makslevental
force-pushed
the
makslevental/xrt-lite
branch
from
October 18, 2024 23:31
dd6cafb
to
3df44d3
Compare
makslevental
force-pushed
the
makslevental/xrt-lite
branch
from
October 18, 2024 23:45
3df44d3
to
93a7ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try this again: this is a HAL that skips/avoids/elides XRT completely. It does so by (essentially) going straight to the XDNA driver's (kmq) shim which talks directly to the kernel module. Note that XDNA's shim actually couples tightly to XRT itself so the bulk of the actual "work" here is/was decoupling. Thus, we vendor the decoupled shim. Just to be explicit/clear: after this PR, on Linux, the only thing needed in the environment is the kernel module itself - not XRT, nor XDNA's shim.
Call outs:
.xclbin
as the artifact and now just load the.pdi
directly;kmq
) path; user-managed queues (umq
) aren't supported until aie4;TODOs before landing:
null
HAL;movehwq
intokernel
shout-out to @benvanik for putting together the
null
HAL lickety-split for me to study while working on this PR.