Remove workarounds for fixed gradio tempfile bugs, and update how gradio is pointed at shark_tmp #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove workarounds for bugs with temporary files generated for images and galleries in previously used gradio versions. * Set the GRADIO_TEMP_DIR environment variable, to point to a directory under shark_tmp if it is not already defined. This is now where gradio will put its temporary files. * Clear previous run temp files by doing shutil.rmtree on the path in GRADIO_TEMP_DIR, rather than the previous methods.
powderluv
approved these changes
Jun 18, 2023
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The recent update of the Gradio version brought in a lot fixes for its temporary file handling with images and galleries. Since the temporary files have been one of the banes of my life with the output gallery work, now we are more up to date I thought I'd better cleanup the existing workarounds that aren't (shouldn't!) be needed anymore and implement the gradio's current method for telling it where to put temporary files.
Changes
Testing
shark_tmpand that nothing is being created in my os temporary file location, during both generation and use of the output gallery. So this does all appear to be working.