Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD] Fix custom model path for WebUI #1260

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Conversation

Abhishek-Varma
Copy link
Contributor

-- This commit fixes custom model path for WebUI.

Signed-off-by: Abhishek Varma abhishek@nod-labs.com

match model:
case "models":
return Path(prefix, "models")
return Path(Path.cwd(), "models")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reverting @dan-garvey patch. Does this work with ckpt_dir provided in the command line ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if --ckpt_loc is being provided to the CLI's exe it works perfectly without touching this part of the code. I tested the CLI for txt2img and it works after this patch too.

This revision concerns WebUI where "prefix" will erroneously become only --ckpt_loc (irrespective of selecting LoRA/Custom Vae) and it'll concatenate models/vae etc to the path.

Let me know if we'd also want to let users access --ckpt_loc when invoking WebUI as well - my understanding is that for WebUI we'd let users keep the checkpoints under models directory, like earlier, and let them pick from the dropdown list.

-- This commit fixes custom model path for WebUI.

Signed-off-by: Abhishek Varma <abhishek@nod-labs.com>
@powderluv powderluv merged commit 3b63645 into nod-ai:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants