Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicate metadata_props field in onnx model causes issue with import #863

Closed
zjgarvey opened this issue Oct 9, 2024 · 1 comment
Closed

duplicate metadata_props field in onnx model causes issue with import #863

zjgarvey opened this issue Oct 9, 2024 · 1 comment
Assignees
@zjgarvey

Comments

@zjgarvey
Copy link
Collaborator

zjgarvey commented Oct 9, 2024

The model "resnetv2_50x1_bit.goog_in21k_ft_in1k_vaiq" has a duplicated metadata_prop item, and causes the onnx checker in the importer to fail.

Will remove this metadata item in a one-off test info class. The test should now fail due to Numerics.
@zjgarvey zjgarvey self-assigned this Oct 9, 2024
This was referenced Oct 9, 2024
Open
Merged
zjgarvey added a commit to nod-ai/SHARK-TestSuite that referenced this issue Oct 9, 2024
@zjgarvey
fix some test setups causing import failures (#365)
ed765fb 
Resolves issues <nod-ai/SHARK-ModelDev#860>
<nod-ai/SHARK-ModelDev#859> and
<nod-ai/SHARK-ModelDev#863>

- 5 tests should newly pass with this change (the vit models listed
under "no_opset_update")
- 1 test "resnetv2_50x1_bit.goog_in21k_ft_in1k_vaiq" should go from an
import fail to a Numerics fail.
@zjgarvey
Copy link
Collaborator Author

resolved with nod-ai/SHARK-TestSuite#365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zjgarvey zjgarvey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zjgarvey