Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous api compat fixes v2 #63

Merged
merged 7 commits into from
Jul 13, 2023
Merged

Miscellaneous api compat fixes v2 #63

merged 7 commits into from
Jul 13, 2023

Conversation

brucekimrokcmu
Copy link
Contributor

This PR is a API compatibility fix, which is similar to this PR #43.
This PR contributes the following:

  • Allow pi.permute to to accept list of Ints as py::args
  • Allow pi.amax() pi.vector_norm() and pi.sum.dim_IntList to accept a scalar dim argument as opposed to only allowing lists of integers
  • Added default value to pi.softplus()

@brucekimrokcmu brucekimrokcmu merged commit fa1c3a2 into main Jul 13, 2023
5 checks passed
@brucekimrokcmu brucekimrokcmu deleted the miscellaneous_api_compat_fixes_v2 branch July 13, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@123epsilon 123epsilon 123epsilon approved these changes

@makslevental makslevental Awaiting requested review from makslevental

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brucekimrokcmu @123epsilon