Skip to content

Conversation

@blackbartblues
Copy link
Contributor

@blackbartblues blackbartblues commented Jan 11, 2026

Summary

This PR adds Polish localization and expands functionality of the Steam Price Watcher plugin.

Changes

1. Polish Language Support

  • Added complete Polish translation (i18n/pl.json)
  • All UI strings translated including panel interface, settings dialog, tooltips, and notifications

2. Expanded Currency Support (10 → 44 currencies)

Added all major Steam-supported currencies:

  • European: EUR, GBP, CHF, CZK, DKK, HUF, NOK, PLN, RON, SEK, UAH
  • Asian: CNY, HKD, IDR, INR, JPY, KRW, MYR, PHP, SGD, THB, TWD, VND
  • Middle East: ILS, KWD, QAR, SAR
  • Americas: ARS, BRL, CAD, CLP, COP, CRC, MXN, PEN, USD, UYU
  • Oceania: AUD, NZD
  • Other: KZT, RUB, TRY, ZAR

Each currency includes proper symbol (€, £, ¥, ₽, zł, etc.)

3. Settings Button in Panel

  • Added settings icon button (⚙️) next to refresh button
  • Opens plugin settings dialog directly from panel
  • Uses proper BarService.openPluginSettings() API
  • No need to navigate through plugin menu to change settings

4. Version Bump

  • Updated from 1.0.2 to 1.1.0

Testing

Tested on Noctalia Shell 4.0.0 with:

  • ✅ All 44 currencies display correctly in dropdown
  • ✅ PLN (Polish Złoty) currency working properly with zł symbol
  • ✅ Polish language translations display correctly throughout UI
  • ✅ Settings button opens plugin settings dialog
  • ✅ Price fetching respects selected currency
  • ✅ No regressions in existing functionality

Files Modified

  • Panel.qml: Added settings button with proper API call
  • Settings.qml: Expanded currency list from 10 to 44 + all symbol mappings
  • i18n/pl.json: Complete Polish translation
  • manifest.json: Version 1.0.2 → 1.1.0

- Expanded currency support from 10 to 44 currencies
- Added all major Steam-supported currencies (PLN, EUR, GBP, etc.)
- Added settings button in Panel to open plugin settings dialog
- Updated currency symbols mapping for all currencies
- Version bump to 1.1.0

This complements the Polish localization with full currency support and improved UX.
@blackbartblues blackbartblues changed the title Add Polish localization for the price watcher feat: Add Polish language, 44 currencies, and settings button Jan 12, 2026
@blackbartblues
Copy link
Contributor Author

@lokize Please review changes if they are again in conflict in your work. Last time I was using help of claude to evaluate my work and it pushed all changes to gh made mess. I am not familliat with GH yet, I am just starting in code online work.

blackbartblues and others added 2 commits January 13, 2026 18:58
- Sync with upstream changes (settings button, Logger, package icon)
- Expand currency list from 10 to 43 Steam currencies
- Translate Portuguese comments to English
- Keep Polish localization (pl.json)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@lokize
Copy link
Contributor

lokize commented Jan 13, 2026

@blackbartblues Please check this, as it doesn’t seem to be properly up to date. I already removed the console.log statements in the last update, but they’re still appearing for you, which suggests you might be working with an older version of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants