-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Redo all necessary DNS records reverted by other PRs #65
Comments
@jimbrig I can redo it since I removed them. Not sure how that happened since I didn't touch those records. |
No worries I've got it all locally on my other laptop and will re-implement adding docs as I go |
Going to add testing suite against the records also with an automated GHA workflow and merge protection to help in the future also |
@phoward38 can you provide insights into the following from above? 1.
|
|
Cool |
@phoward38 when you merged the various pull requests (#59 #60 #61 #62 #63 and #64), you removed all the work I did yesterday for some pretty advanced DNS records.
For example, in PR #59 's DNSControl GitHub Workflow Preview Output:
Notice that the following changes occurred:
spf
(TXT
) record got modified adding two additional, unecessary domains:amazonses.com
andstripe.com
; we only need_spf.google.com
)CAA
record for issuing certificated from https://letsencrypt.org got deleted - this is necessary for providing HTTPS support for the neededmta-sts.noclocks.dev
sub-domain which hosted the MTS-STS policy file.CNAME
record changed fromhixie
topixie
(not sure about this one)TXT
records_dmarc
TXT
policy record which was how we wanted it to be_mta-sts
record which is neededsenja.io
?I will create issues and PRs and re-do everything.
The text was updated successfully, but these errors were encountered: