Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement smartcase search #366

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Implement smartcase search #366

merged 2 commits into from
Jun 2, 2023

Conversation

resolritter
Copy link
Contributor

close #365

@noborus
Copy link
Owner

noborus commented Jun 1, 2023

Thank you for the pull request.
It certainly seems better to have this.

@noborus
Copy link
Owner

noborus commented Jun 2, 2023

In this PR, smartcase is not displayed correctly in highlight display.
This is because FindAllString is done separately from searcher, and it is caused by the original code.
I would like to add FindAll and word methods to the searcher interface.

I'm thinking of adding this fix after merging.
thank you.

@noborus noborus merged commit fa64ef8 into noborus:master Jun 2, 2023
@resolritter resolritter deleted the smartcase branch June 2, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for smartcase search
2 participants
@resolritter @noborus