Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piping ov to ov breaks commands and terminal #634

Closed
KapJI opened this issue Oct 6, 2024 · 3 comments
Closed

Piping ov to ov breaks commands and terminal #634

KapJI opened this issue Oct 6, 2024 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@KapJI
Copy link

KapJI commented Oct 6, 2024 •
edited
Loading

Repro

> ov file | ov

Then type /private.

Expected behaviour: private is searched. First ov prints output to stdout and doesn't affect the next call.
Actual behaviour: Mode selection menu appears when p is pressed. Unable to exit with q, terminal session is corrupted. It seems both processes are reading commands and interfering with each other.

Without piping it works fine.

Why I need to pass ov to ov?

I have some tools which are configured to use ov by default, e.g. I want this: delta --help | bat -l help.
less handles such case fine.

Info

> ov --version
ov version 0.36.0 rev:d671c94

Platforms: MacOS, Linux
@noborus
Copy link
Owner

noborus commented Oct 7, 2024

Thank you for Issue.

This is certainly a problem.
I want to redirect the ov while displaying it on the screen, but if it starts twice, there will be problems.

@noborus noborus added bug Something isn't working enhancement New feature or request labels Oct 7, 2024
noborus added a commit that referenced this issue Oct 15, 2024
@noborus
Change to Do not display screen when redirecting
c25d495 
Changes the default to not display the screen when redirecting.
Requires the `--force-screen` option to display the screen.

This is a fix for #634.
@noborus noborus mentioned this issue Oct 15, 2024
Merged
@noborus
Copy link
Owner

noborus commented Oct 16, 2024

Changed so that the screen is not displayed when output is redirected.
The --force-screen option is now required to display the screen.

@KapJI
Copy link
Author

KapJI commented Oct 16, 2024

Thanks! I built it from sources and this case with piping works now.

@KapJI KapJI closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@noborus @KapJI