try warning #1
Open
try warning #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noboru-i
force-pushed
the
master
branch
2 times, most recently
from
a8583fd to
099ad37
Compare
noboru-i
force-pushed
the
sample-warnings
branch
2 times, most recently
from
37b6be8 to
1cfea66
Compare
| end | ||
|
|
||
| # Test Rubocop warning (Naming/PredicateName) | ||
| def has_title |
There was a problem hiding this comment.
Naming/PredicateName: Rename has_title to title?. (https://github.com/rubocop-hq/ruby-style-guide#bool-methods-qmark) |
| end | ||
|
|
||
| # Test reek warning (TooManyStatements) | ||
| def too_many |
There was a problem hiding this comment.
| Metrics/MethodLength: Method has too many lines. [13/10] (https://github.com/rubocop-hq/ruby-style-guide#short-methods) |
noboru-i
force-pushed
the
sample-warnings
branch
from
1cfea66 to
122f707
Compare
| end | ||
|
|
||
| # Test Rails Best Practices warning (remove unused methods) | ||
| def unused_method |
There was a problem hiding this comment.
| remove unused methods (Article#unused_method) |
| end | ||
|
|
||
| # Test reek warning (TooManyStatements) | ||
| def too_many |
noboru-i
force-pushed
the
sample-warnings
branch
from
122f707 to
33b3874
Compare
| import '../stylesheets/application.css'; | ||
|
|
||
| console.log('Hello World from Webpacker'); | ||
| console.log('Hello World from Webpacker') |
| @@ -1,3 +1,3 @@ | |||
| body { | |||
| color: red; | |||
| color: red; | |||
There was a problem hiding this comment.
| Expected indentation of 2 spaces (indentation) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.