Update README.md #21
Merged
Update README.md #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 'discoverById' in the usage example for clarity.
@sandeepmistry
hello! awesome library btw (this and noble)
I think this change makes it easier to get started. Lazy people like me who don't read the whole readme could be confused by the usage example. Its not obvious that
discovercalls the callback for only the first device detected. If I were to just copy this and try it out now It could find my phone first instead of my target device, which could cause more confusion.Also
YourThingandyourThingcan look the same when you don't look closely. This makes it impossible not to understand it is the instance ofYourThing.