Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(actions): allow passing string parameters to actions #188

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

nobe4
Copy link
Owner

@nobe4 nobe4 commented Oct 2, 2024

This prepares later work for #187. Passing parameter will enable additional customization in the REPL and later in the config as well.

Only the Debug action currently uses this new parameter, to confirm it's receiving it correctly.

Also have to do some workaround a bubble limitation, see charmbracelet/bubbles#630

This prepares later work for #187. Passing parameter will enable
additional customization in the REPL and later in the config as well.

Only the `Debug` action currently uses this new parameter, to confirm
it's receiving it correctly.

Also have to do some workaround a bubble limitation, see
charmbracelet/bubbles#630
@nobe4 nobe4 merged commit 82482fa into main Oct 2, 2024
6 checks passed
@nobe4 nobe4 deleted the actions-parameters branch October 2, 2024 11:58
nobe4 added a commit that referenced this pull request Oct 2, 2024
This build on #188 and allow to specify arguments in the rules.

E.g.

```yaml
rules:
  - name: test
    action: debug
    args: ["a", "b"]
```

cc #187
@nobe4 nobe4 assigned nobe4 and unassigned nobe4 Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant