Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in point source emission #24

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

lwcugb
Copy link
Collaborator

@lwcugb lwcugb commented Sep 18, 2024

PR Checklist

  • This PR has been tested on an RDHPCS machine and/or WCOSS2. Please select below:

    • [! ] RDHPCS.
    • WCOSS2.
  • [ !] This PR has been tested with the ufs-srweather-app workflow aqm-dev branch.

  • New or updated input data is required by this PR.

  • Baselines are expected to change.

Description

There is a bug in the point source emissions, in which only the first layer emissions are read in. This leads to much lower SO2. It is solved through this PR. Other changes are related to the emission unit, which has no impact on the results.

Issue(s) addressed

SO2 is too low after the updates to be coupled with CMAQ54.

Dependencies

Better handle of the emission unit. This will not impact the simulation results.
Resolve a bug in point source emission. Only the first layer emission is included with his bug, which leads to much lower SO2 simulations.
Copy link
Member

@bbakernoaa bbakernoaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these look ok to me

@ytangnoaa ytangnoaa merged commit 7bfe2e2 into noaa-oar-arl:feature/cmaq54 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants