Feature/cmaq54 li #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forget to turn on AOD
|
@lwcugb Added this because it would not compile in this branch on Hera. This is the place we should have already had all changes that Wei made, so I think we can just merge this in right away so I can run the longer test on Hera. |
drnimbusrain
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
@lwcugb I approve these, as seems like these are mostly what changes you had made and we discussed (at least at high level) previously during our meetings and your tests. I thought these were already here in this branch which will be used to deliver.
Please let us know if there is anything else you are concerned with, or not fully understanding. Otherwise, I will merge this into the branch now and test compilation/run on Hera.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
This PR has been tested on Orion
This PR has been tested with the ufs-srweather-app workflow AQM/production branch.
New or updated input data is required by this PR.
Description
This update to CMAQv5.4 can run through without errors (tested with AQM/production branch on Orion)
Dependencies
Needs new aqm.rc, diag, and field tables