feat(tfmx): play Dynamic Synthesizer via libtfmx 1.0.14 bump - #105
Merged
Conversation
Bump the vendored decoder v1.0.7 -> v1.0.14 (upstream tag `1.0.14`,
commit a07d8860) and rebuild public/libtfmx.worklet.js. 1.0.10 added
Chris Hülsbeck's Dynamic Synthesizer decoder (src/Chris/DNS/); 1.0.11-14
add playback fixes incl. Turrican III and the v1.0.9 loop-mode duration
regression fix our old 1.0.7 pin was missing. Rebuilt from source under
emscripten 6.0.2; no public C-API change, so the worklet bindings are
untouched.
Make Dynamic Synthesizer pairs actually decode. libtfmx's DNS decoder
discovers its sample bank by the `dns.`<->`smp.` filename token, NOT the
generic `.tfx`->`.sam` guess the Hülsbeck-TFMX conventions use — so the
worklet's hardcoded `.tfx`/`.sam` MEMFS normalisation makes tfx_load
fail (verified `load=0` against a real Modland dns.ptc/smp.ptc pair).
Fix: the play message carries a `dns` boolean (derived from the
`dns.`-prefixed data-half filename) and the worklet writes DNS halves as
`dns.<base>`/`smp.<base>`. Other pair conventions are unchanged.
Verified: DNS pair decodes ("Dynamic Synthesizer (AMIGA)", 17.3s,
non-silent PCM) via a headless wasm harness AND end-to-end through the
app's tfmx-library path (play OK, no error). Regression: FC + Hippel
still decode and play post-bump. `make verify` green; 252 unit tests.
Companion to the routing slice in #104. Refs #103.
Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Ronny Trommer <ronny@no42.org>
indigo423
added a commit
that referenced
this pull request
Jul 10, 2026
…106) Complete the two deferred test tasks for Dynamic Synthesizer support (#104/#105 shipped the feature; these add unit coverage). - Extract the worklet `dns` flag derivation from Player.tsx's inline regex into a pure exported helper `isDnsDataHalf(name)` in lib/tfmx/pairs.ts, and unit-test it: `dns.`-prefixed true (spaces, case-insensitive), literal dot required (`dnsomething.mod` false), sample half + other conventions false, empty false. - Test the byte-server's two gates for dns./smp. by exercising the predicates pages/api/library/file.ts uses — parseHalfName (allowlist) + detectPairsInDir (partner existence) — mirroring the repo's predicate-level convention (random.test.ts), not a mounted handler. Served when the partner exists, 404 for an orphan dns. half, 404 for a non-allowlisted path. Full suite 260 passed; typecheck + lint clean. Refs #103 Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Ronny Trommer <ronny@no42.org>
This was referenced Jul 10, 2026
indigo423
added a commit
that referenced
this pull request
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes Dynamic Synthesizer support. Companion to the routing slice in #104 (now on
main) — this brings the decoder and makes DNS pairs actually play. Closes the goal of #103.What
Vendor bump
v1.0.7 → v1.0.14(vendor/libtfmxaudiodecoder/, tag1.0.14, commita07d8860) + rebuiltpublic/libtfmx.worklet.jsfrom source under emscripten 6.0.2.src/Chris/DNS/).ccallbindings are untouched.Make DNS pairs decode (
public/tfmx.worklet.js,lib/audio-player.ts,components/Player.tsx). This is the part that went beyond the original routing-only scope, and it's the crux:The worklet's hardcoded
.tfx/.samMEMFS normalisation therefore makestfx_loadfail for DNS. Fix: theplaymessage carries adnsboolean (derived from thedns.-prefixed data-half filename), and the worklet writes DNS halves asdns.<base>/smp.<base>. Every other pair convention is untouched.How it was found + verified
A headless Node harness loading the built wasm and replaying the worklet's exact load sequence:
tfx_load<base>.tfx/<base>.sam(old pair path)fmt="???"dns.<base>/smp.<base>(new)End-to-end through the real app (run-coolmodfiles driver,
LIBRARY_ROOTfixture with a real Modlanddns.ptc/smp.ptcpair):play: OK (tfmx-library), no error, renders asptc (TFMX).Future Composer 1.0-1.3) and Hippel (Compressed TFMX/Hippel) still decode (wasm harness) and FC plays through the app (tfmx-single-library).dns./smp.halves served (200) with partner; lonedns.half → 404 (orphan rejection intact).make verifygreen (lint + typecheck + 252 unit tests + audit +next build).Notes
public/libtfmx.worklet.js, 261→274 KB) is a committed generated asset perVENDORING.md; the vendored source it was built from is in the same commit (GPL corresponding-source requirement).add-amiga-prefix-filenames(itsrenderTfmxPairLabelhardcodesmdat./smpl.).Refs #103
🤖 Generated with Claude Code