Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the travis CI config no longer works, and thought I'd make an MR with a similar GitHub actions build which should just work out of the box. It's pretty much just the node.js action template with the following changes:
Node version: set to build on node.js 6.x (like the old travis build, presumably to test compatibility) and the current node.js LTS 16.x.
npm installinstead ofnpm ciin the template:npm ciis nicer, but doesn't work with node 6.xRun
npm run benchmarkin addition tonpm testI've checked the CI works using an MR on my fork - see ictrobot#1. Feel free to close though if you'd prefer to do it yourself or try to fix the travis CI.