[API] Add ML LXM Service API(internal) for large model interactons#646
Open
songgot wants to merge 1 commit intonnstreamer:mainfrom
Open
[API] Add ML LXM Service API(internal) for large model interactons#646songgot wants to merge 1 commit intonnstreamer:mainfrom
songgot wants to merge 1 commit intonnstreamer:mainfrom
Conversation
jaeyun-jung
reviewed
Aug 29, 2025
jaeyun-jung
reviewed
Aug 29, 2025
jaeyun-jung
reviewed
Aug 29, 2025
jaeyun-jung
reviewed
Aug 29, 2025
jaeyun-jung
reviewed
Aug 29, 2025
jaeyun-jung
reviewed
Aug 29, 2025
0dd8e4b to
324bf4a
Compare
jaeyun-jung
reviewed
Aug 29, 2025
86a8dd5 to
9a94a33
Compare
9a94a33 to
3306bc8
Compare
This commit introduces the ML LXM Service API, a new C API designed to facilitate interactions with large-scale models such as Large Language Models (LLMs) Signed-off-by: hyunil park <hyunil46.park@samsung.com>
3306bc8 to
f0c6e84
Compare
hj210
approved these changes
Oct 20, 2025
hj210
left a comment
There was a problem hiding this comment.
This API has a solid foundation and demonstrates clear design goals
and consistent implementation. It is particularly well-aligned with
its specific purpose of interacting with LLMs/LVMs.
With some small refactoring, it could become cleaner and more maintainable code.
| * @return ML_ERROR_NONE on success. | ||
| * @note The callback parameter is mandatory and will be set during session creation. | ||
| */ | ||
| int ml_lxm_session_create (const char *config_path, const char *instructions, ml_service_event_cb callback, void *user_data, ml_lxm_session_h * session); |
There was a problem hiding this comment.
This function has a long parameter list. It would be better to reduce the number of parameters by using a structure type if possible.
For example,
typedef struct {
const char *config_path;
const char *instructions;
ml_service_event_cb callback;
void *user_data;
} ml_lxm_session_config_t;
int ml_lxm_session_create(const ml_lxm_session_config_t *config,
ml_lxm_session_h *session) {
if (!config || !session || !config->config_path || !config->callback)
return ML_ERROR_INVALID_PARAMETER;
return ml_lxm_session_create(config->config_path, config->instructions,
config->callback, config->user_data, session);
}(This sample code is suggested by Cline)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces the ML LXM Service API, a new C API designed to facilitate interactions with large-scale models such as Large Language Models (LLMs)