Skip to content

Commit

Permalink
Enable deprecated-typing-alias check [pylint] (home-assistant#63935)
Browse files Browse the repository at this point in the history
  • Loading branch information
cdce8p authored Jan 12, 2022
1 parent 2178130 commit 2d2944d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .core_files.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ core: &core
- homeassistant/helpers/*
- homeassistant/package_constraints.txt
- homeassistant/util/*
- pyproject.yaml
- pyproject.toml
- requirements.txt
- setup.cfg

Expand Down
4 changes: 4 additions & 0 deletions homeassistant/components/harmony/subscriber.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

import asyncio
import logging

# pylint: disable-next=deprecated-typing-alias
# Issue with Python 3.9.0 and 3.9.1 with collections.abc.Callable
# https://bugs.python.org/issue42965
from typing import Any, Callable, NamedTuple, Optional

from homeassistant.core import callback
Expand Down
2 changes: 0 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ good-names = [
# Enable once current issues are fixed:
# consider-using-namedtuple-or-dataclass (Pylint CodeStyle extension)
# consider-using-assignment-expr (Pylint CodeStyle extension)
# deprecated-typing-alias (temporarily while updating code to Python 3.9)
disable = [
"format",
"abstract-class-little-used",
Expand All @@ -102,7 +101,6 @@ disable = [
"consider-using-f-string",
"consider-using-namedtuple-or-dataclass",
"consider-using-assignment-expr",
"deprecated-typing-alias",
]
enable = [
#"useless-suppression", # temporarily every now and then to clean them up
Expand Down

0 comments on commit 2d2944d

Please sign in to comment.