Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions requires-optional.txt
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,5 @@ shapely

## image uri conversion ##
pillow
filelock>=3.20.1 # not directly required, pinned by Snyk to avoid a vulnerability
tornado>=6.5.3 # not directly required, pinned by Snyk to avoid a vulnerability
Comment on lines +57 to +58

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While pinning these transitive dependencies is important for security, they seem misplaced under the ## image uri conversion ## section. tornado is a dependency of Jupyter, and filelock is likely a dependency of development tools like pre-commit. For better maintainability, it would be clearer to either move them to their respective sections (e.g., tornado under ## jupyter ##) or create a new section for pinned transitive dependencies, for example ## Pinned for security ##.