[Snyk] Security upgrade urllib3 from 1.26.20 to 2.6.0

[nn6n]

Snyk has created this PR to fix 2 vulnerabilities in the pip dependencies of this project.

Snyk changed the following file(s):

• test_requirements/requirements_311_core.txt

⚠️ Warning

equests 2.25.1 requires urllib3, which is not installed.

---

Important

• Check the changes in this PR to ensure they won't cause issues with your project.
• Max score is 1000. Note that the real score may have changed since the PR was raised.
• This PR was automatically created by Snyk using the credentials of a real user.
• Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

---

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

---

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Allocation of Resources Without Limits or Throttling

[gemini-code-assist]

Summary of Changes

Hello @nn6n, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated security fix initiated by Snyk to resolve two vulnerabilities found in the project's dependencies. It primarily involves upgrading the urllib3 package to its latest secure version, 2.6.0, ensuring the project's testing environment benefits from the latest security patches.

Highlights

• Security Vulnerability Fix: This pull request, automatically generated by Snyk, addresses two identified security vulnerabilities within the project's pip dependencies.
• Dependency Upgrade: The urllib3 package has been upgraded from version 1.26.20 to 2.6.0 to mitigate the security risks.
• Requirements File Update: The test_requirements/requirements_311_core.txt file was modified to include the updated urllib3 dependency, explicitly pinned to version 2.6.0.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request from Snyk aims to fix a security vulnerability in urllib3 by upgrading it. However, the current implementation is flawed and will break your dependency installation. The main issue is a dependency conflict: requests==2.25.1 (present in test_requirements/requirements_311_core.txt) requires urllib3<1.27, but this PR attempts to install urllib3>=2.6.0. These versions are incompatible. To resolve this, requests must also be upgraded to a version compatible with urllib3 v2 (e.g., requests>=2.30.0).

Furthermore, this security fix is incomplete:

1. Other files are affected: The same vulnerability likely exists in other requirement files that also use requests==2.25.1 (e.g., for Python 3.8, 3.9, 3.10) but they have not been updated.
2. Python version incompatibility: The upgrade to urllib3 v2 is not compatible with Python 3.8 and 3.9. For those environments, you'll need to pin urllib3 to a secure 1.x version.

I've left a specific comment on the introduced change. I recommend addressing these issues across all relevant files to fully resolve the vulnerability.

[gemini-code-assist]

This added dependency urllib3>=2.6.0 conflicts with requests==2.25.1 (from line 1), which has a requirement of urllib3<1.27. This will cause dependency resolution to fail during installation.

To fix this, requests must be upgraded to a version compatible with urllib3 v2 (e.g., requests>=2.30.0). Since this is an automated PR, you may need to manually intervene to upgrade requests in this file and other similar requirement files across the repository.