[Snyk] Fix for 6 vulnerabilities

[nn6n]

Snyk has created this PR to fix 6 vulnerabilities in the pip dependencies of this project.

Snyk changed the following file(s):

• test_requirements/requirements_38_optional.txt

⚠️ Warning

equests 2.25.1 requires urllib3, which is not installed.
qtconsole 5.4.4 requires pyzmq, which is not installed.
notebook 6.5.7 requires pyzmq, which is not installed.
jupyter-server 1.24.0 requires pyzmq, which is not installed.
jupyter-console 6.6.3 requires pyzmq, which is not installed.
jupyter-console 6.6.3 has requirement ipykernel>=6.14, but you have ipykernel 5.5.3.
jupyter-client 7.4.9 requires pyzmq, which is not installed.
ipyparallel 8.6.1 requires pyzmq, which is not installed.

---

Important

• Check the changes in this PR to ensure they won't cause issues with your project.
• Max score is 1000. Note that the real score may have changed since the PR was raised.
• This PR was automatically created by Snyk using the credentials of a real user.
• Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

---

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

---

Learn how to fix vulnerabilities with free interactive lessons:

🦉 XML Injection
🦉 Allocation of Resources Without Limits or Throttling

[gemini-code-assist]

Summary of Changes

Hello @nn6n, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enhance the security posture of the project by applying automated fixes for multiple identified vulnerabilities in its Python dependencies. It specifically targets and updates several packages to their secure versions, ensuring the project's development and testing environments are protected against known security risks.

Highlights

• Vulnerability Fixes: This pull request, automatically generated by Snyk, addresses and fixes 6 identified vulnerabilities within the project's pip dependencies.
• Dependency Updates: The test_requirements/requirements_38_optional.txt file has been updated to pin fonttools to >=4.61.0, tornado to >=6.5.3, and urllib3 to >=2.6.0 to resolve these vulnerabilities.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request from Snyk aims to fix several vulnerabilities by pinning fonttools, tornado, and urllib3. While addressing security issues is important, there are a couple of problems with the current implementation.

First, as noted in my comment, the upgrade to urllib3>=2.6.0 is incompatible with requests==2.25.1, which is also a dependency for Python 3.8 tests. This will break dependency resolution. I've suggested using a compatible version of urllib3 that still patches the vulnerability.

Second, these dependency pins are only added to test_requirements/requirements_38_optional.txt. The vulnerabilities likely affect other Python environments supported by this project (3.9, 3.10, 3.11). The fix should be applied to the corresponding requirements_*_optional.txt files for other Python versions to ensure the vulnerabilities are addressed consistently across all test environments. As it stands, this PR is an incomplete fix.

[gemini-code-assist]

The suggested version urllib3>=2.6.0 is incompatible with requests==2.25.1 (defined on line 1), which requires urllib3<1.27. This will cause dependency resolution to fail.

To fix the urllib3 vulnerabilities while maintaining compatibility, you should pin urllib3 to a secure 1.x version. The vulnerabilities are fixed in version 1.26.17. Pinning to 1.26.18 (the latest 1.x release) is a safe and compatible choice.

urllib3==1.26.18 # not directly required, pinned by Snyk to avoid a vulnerability