-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade urllib3 from 1.26.20 to 2.5.0 #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…bilities The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-10390193 - https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-10390194
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @nn6n, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request, automatically generated by Snyk, aims to resolve two identified security vulnerabilities by upgrading the urllib3 dependency to version 2.5.0. The change specifically pins this version in the optional test requirements to ensure the fix is applied.
Highlights
- Security Vulnerability Fix: This pull request addresses two identified security vulnerabilities by upgrading the
urllib3package from version1.26.20to2.5.0. - Dependency Version Pinning: The
urllib3dependency is now explicitly pinned to version2.5.0intest_requirements/requirements_38_optional.txt, with a comment indicating it's a security-driven pin rather than a direct requirement.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades urllib3 to fix security vulnerabilities. However, the proposed version urllib3>=2.5.0 is incompatible with the Python 3.8 environment targeted by test_requirements/requirements_38_optional.txt. Specifically, urllib3 2.x requires Python 3.10+ and conflicts with the pinned requests==2.25.1 dependency which requires urllib3<1.27. The change should be reverted and a compatible, secure version from the urllib3 1.x series should be used instead.
| pyarrow | ||
| narwhals>=1.15.1 | ||
| anywidget==0.9.13 | ||
| urllib3>=2.5.0 # not directly required, pinned by Snyk to avoid a vulnerability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upgrade to urllib3>=2.5.0 introduces an incompatible version for this Python 3.8 environment, which will break the dependency installation. urllib3 v2.x requires Python 3.10 or newer, and conflicts with the pinned requests==2.25.1 dependency (line 1) which requires urllib3<1.27. To fix the security vulnerability while maintaining compatibility, pin urllib3 to a secure version from the 1.x series. Revert this change.
Snyk has created this PR to fix 2 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
test_requirements/requirements_38_optional.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Open Redirect