-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade urllib3 from 1.26.20 to 2.5.0 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ities The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-10390193 - https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-10390194
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @nn6n, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses security vulnerabilities by upgrading the urllib3 dependency and pinning it to a specific version in the test requirements file. The upgrade was initiated by Snyk's automated vulnerability scanning and remediation process.
Highlights
- Security Upgrade: Upgraded the
urllib3dependency from version 1.26.20 to 2.5.0 to address identified security vulnerabilities. - Dependency Pinning: Pinned the
urllib3version intest_requirements/requirements_310_core.txtto ensure the upgraded version is used, even though it's not a direct dependency. - Snyk Automated PR: This PR was automatically created by Snyk to fix vulnerabilities in the project's pip dependencies.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix a security vulnerability in urllib3. However, the proposed upgrade to urllib3>=2.5.0 is a major version bump and is incompatible with the currently pinned requests==2.25.1, which will break the dependency installation.
I've provided a suggestion to pin urllib3 to a non-breaking version that also contains the security fix.
Additionally, this change was only applied to requirements_310_core.txt. The other requirement files (requirements_38_core.txt, requirements_39_core.txt, requirements_311_core.txt, requirements_312_core.txt) also use the same vulnerable requests version and its transitive dependency urllib3. For consistency and to fully mitigate the vulnerability across all test environments, these files should probably be updated as well.
| @@ -1,3 +1,4 @@ | |||
| requests==2.25.1 | |||
| pytest==7.4.4 | |||
| narwhals>=1.15.1 | |||
| urllib3>=2.5.0 # not directly required, pinned by Snyk to avoid a vulnerability | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade to urllib3>=2.5.0 introduces a breaking change that is incompatible with requests==2.25.1 (defined on line 1), which requires urllib3<1.27. This will cause dependency resolution failures.
The vulnerabilities this PR aims to fix (SNYK-PYTHON-URLLIB3-10390193, SNYK-PYTHON-URLLIB3-10390194) are also patched in urllib3 version 1.26.17.
To fix the vulnerabilities without introducing breaking changes, I suggest pinning to a compatible version of urllib3.
urllib3>=1.26.17,<1.27 # Pinned to avoid vulnerabilities, compatible with requests==2.25.1
Snyk has created this PR to fix 2 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
test_requirements/requirements_310_core.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Open Redirect