[Snyk] Security upgrade urllib3 from 2.2.3 to 2.5.0

[nn6n]

Snyk has created this PR to fix 2 vulnerabilities in the pip dependencies of this project.

Snyk changed the following file(s):

• requires-optional.txt

⚠️ Warning

otebook 6.5.7 requires pyzmq, which is not installed.
jupyter-server 1.24.0 requires pyzmq, which is not installed.
jupyter-console 6.6.3 requires pyzmq, which is not installed.
jupyter-client 7.4.9 requires pyzmq, which is not installed.
ipykernel 6.16.2 requires pyzmq, which is not installed.
geopandas 0.10.2 requires pyproj, which is not installed.

---

Important

• Check the changes in this PR to ensure they won't cause issues with your project.
• Max score is 1000. Note that the real score may have changed since the PR was raised.
• This PR was automatically created by Snyk using the credentials of a real user.
• Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

---

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

---

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Open Redirect

[gemini-code-assist]

Summary of Changes

Hello @nn6n, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading the urllib3 Python library. The upgrade specifically targets known vulnerabilities within the older version, ensuring the project utilizes a more secure and up-to-date dependency.

Highlights

• Security Upgrade: This pull request upgrades the urllib3 dependency from version 2.2.3 to 2.5.0 to address two identified security vulnerabilities (SNYK-PYTHON-URLLIB3-10390193 and SNYK-PYTHON-URLLIB3-10390194).
• Dependency Pinning: A direct dependency pin for urllib3>=2.5.0 has been added to requires-optional.txt. This pin is explicitly noted as being for security purposes by Snyk, rather than a direct functional requirement.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request, automatically generated by Snyk, aims to upgrade urllib3 to mitigate security vulnerabilities. While the intention is correct, the proposed change introduces a critical dependency conflict with the requests package version used in the Python 3.12 test environment, which will likely cause build failures. I've also provided a suggestion to improve the organization of this requirements file for better maintainability. The dependency conflict must be resolved before this PR can be merged.

[gemini-code-assist]

This change introduces a dependency conflict that will likely break the test environment for Python 3.12.

• This PR pins urllib3 to version >=2.5.0.
• The file test_requirements/requirements_312_optional.txt pins requests to requests==2.31.0.
• requests==2.31.0 has a dependency on urllib3<2.2,>=1.21.1.

These version constraints are incompatible and will cause a dependency resolution error when pip tries to install dependencies for the Python 3.12 test suite.

To fix this, you'll also need to update the requests dependency in test_requirements/requirements_312_optional.txt to a version that supports urllib3>=2.5.0, for example, requests>=2.32.0.

[gemini-code-assist]

While pinning this dependency is important for security, placing it under the ## image uri conversion ## section could be misleading. urllib3 is a general-purpose HTTP library used by other dependencies like requests, and its use is not limited to image URI conversion.

For better clarity and long-term maintainability, I'd recommend grouping such security-related pins under a dedicated section. For example:

...
pillow

## Security Pins ##
urllib3>=2.5.0 # Pinned by Snyk to mitigate vulnerability

This makes it clear why this dependency is listed and pinned here, improving the file's readability.