Skip to content

[Snyk] Security upgrade requests from 2.25.1 to 2.32.4 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nn6n
Copy link
Owner

@nn6n nn6n commented Jun 13, 2025

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.

Snyk changed the following file(s):

  • test_requirements/requirements_311_core.txt

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

…ities

The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-REQUESTS-10305723
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @nn6n, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request was automatically generated by Snyk to address a security vulnerability by upgrading the requests dependency to a newer version in one of the test requirement files.

Highlights

  • Security Upgrade: Upgrade the requests library to version 2.32.4 to fix a reported vulnerability identified by Snyk.
  • Dependency File Update: The upgrade is applied specifically within the test_requirements/requirements_311_core.txt file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, upgrades the requests library from version 2.25.1 to 2.32.4 in test_requirements/requirements_311_core.txt. This update is intended to address vulnerability SNYK-PYTHON-REQUESTS-10305723.

While updating requests is a crucial security measure, there's a critical oversight that needs immediate attention:

  • Inconsistent Dependency Update: The requests library has only been updated in the requirements file for Python 3.11 (test_requirements/requirements_311_core.txt). The corresponding files for Python 3.10 (test_requirements/requirements_310_core.txt) and Python 3.12 (test_requirements/requirements_312_core.txt) still list requests==2.25.1. If this older version is indeed vulnerable (as implied by this PR), the project remains exposed to SNYK-PYTHON-REQUESTS-10305723 in test environments for Python 3.10 and 3.12. It is imperative to update requests to version 2.32.4 (or a similarly patched version) in all relevant requirements files (test_requirements/requirements_310_core.txt and test_requirements/requirements_312_core.txt) to ensure comprehensive remediation of the vulnerability.

Additionally, considering the version jump for requests:

  • Thorough Testing: Please ensure that comprehensive tests are run across all supported Python versions (3.10, 3.11, and 3.12) after applying these changes consistently. This will help confirm that the upgrade does not introduce any regressions or compatibility issues, even though Snyk's metadata indicates isBreakingChange:false.

Addressing the inconsistent update across all Python version-specific requirement files is essential for maintaining the security of the project.

Comment on lines +1 to 3
requests==2.32.4
pytest==7.4.4
narwhals>=1.15.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version for requests has been updated. It's also a good practice to ensure text files end with a newline character. This can prevent issues with some tools and improve diff readability when new lines are added to the end of the file in the future.

requests==2.32.4
pytest==7.4.4
narwhals>=1.15.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants