empty quotes attempt #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
one test is failing, looks like tapzero doesn't like empty strings |
complected
reviewed
May 26, 2022
complected
reviewed
May 26, 2022
complected
reviewed
May 26, 2022
|
Just FYI, I was talking about how the node-ebnf visualizer is incorrect and I was searching for an alternative i.e. standalone bare string Could you please add a simple test for standalone barestrings:
|
|
Looks good to me! No other issues from me. |
dmfxyz
reviewed
May 27, 2022
|
@trouaux feel free to ignore literally everyone since they are taking you in circles, just DM me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.