Fix/issue 429 transaction - #1
Merged
Merged
Conversation
# Conflicts: # .github/workflows/preview.yml # .github/workflows/publish.yml # .github/workflows/pull-request.yml
- SET NOCOUNT ON - Wrap keywords in brackets ([Version], [Messages]) - formatting: each column on it's own line. Best practice for maintainability of procedures - proper casing of keywords (INT, AND) - use alias to DELETE statement - semicolons
- SET NOCOUNT ON - Wrap keywords in brackets ([Messages]) - formatting: each column on it's own line. Best practice for maintainability of procedures - proper casing of keywords (INT, BIGINT) - remove 'Messages.' from query since it was redundant - semicolons
- SET NOCOUNT ON - Wrap keywords in brackets ([Version], [Messages]) - formatting: each column on it's own line. Best practice for maintainability of procedures - proper casing of keywords (INT) - remove 'Messages.' from query since it was redundant - semicolons
- SET NOCOUNT ON - Wrap keywords in brackets ([Version], [Messages]) - formatting: each column on it's own line. Best practice for maintainability of procedures - proper casing of keywords (INT) - remove 'Messages.' from query since it was redundant - semicolons
- SET NOCOUNT ON - formatting: each column on it's own line. Best practice for maintainability of procedures - use aliases - semicolons
- SET NOCOUNT ON - formatting: each column on it's own line. Best practice for maintainability of procedures - proper casing of keywords (AND) - semicolons
- SET NOCOUNT ON - remove unused declared variables - specify all parameters when calling [check_stream] procedure - formatting: each column on it's own line. Best practice for maintainability of procedures - proper casing of keywords (IF, ISNULL, NVARCHAR) - use alias to UPDATE statement - remove 'AS' keyword - semicolons
- consistent casing of [Version] column - explicitly specify NULLable columns
SQL Server schema change so that Messages.Created is NOT NULL. This is safe and accurate to do since append_events will always set this value if a NULL is provided to the procedure.
- Messages TABLE
- JsonMetaData is NOT NULL
- json columns are checked to ensure they contain json data
- StreamMessage TYPE
- json_metadata is NOT NULL
…hat in the scripts
…move redundencies in the CHECK definition
…e naming' warning that bito-code-review flagged
- Wrapped append_events logic in a single transaction with SET XACT_ABORT ON - Changed @stream_name parameter to NVARCHAR(850) for consistency - Added guard clause for empty @messages - Introduced @Inserted table to capture inserted GlobalPosition values atomically - Updated Streams.[Version] within the same transaction - Normalized optimistic concurrency errors (2627, 2601) to client-detectable messages - Thrown error messages still StartsWith 'WrongExpectedVersion' but now also includes the full SQL error text for client tracing - Removed redundant post-commit queries and error-parsing logic Fixes issue Eventuous#429
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.