support for macOS armv8.5-a (MBP M1 Pro/Max) #359
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With python 3.9.9 for MBP armv8.5-a, this commit could allow successfully installation via "pip install ." in the directory.
|
It seems like this will break compatibility with other systems. |
|
Make it a seperate branch called arm？ |
|
This can be an option. Another option is to make a check in the script for armv. |
|
closed as #363 is merged to develop. Please let me know if that is not ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With python 3.9.9 for MBP armv8.5-a, this commit could allow successfully installation via "pip install ." in the directory.