Expose CMake target for use via FetchContent #340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows other CMake projects to include HNSW via CMake's
FetchContent
approach, e.g.,A real-world example is available at https://github.com/LTLA/knncolle/blob/master/extern/CMakeLists.txt.
I moved the test building directives into a conditional that only triggers when actually building Hnswlib. This ensures that downstream projects are not saddled with the need to build the tests when all they want are the headers.
I also took the liberty of making
getDataByLabel
const
, to indicate that it could be safely used in parallel frameworks that do not expect modifications to the index upon query; and I added a missing header for<deque>
.