Skip to content

Move setup.py into root folder #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 7, 2021
Merged

Move setup.py into root folder #260

merged 10 commits into from
Jan 7, 2021

Conversation

dyashuni
Copy link
Contributor

There is a build issue in Windows: symlink doesn't work in git. Therefore it is not possible to build python bindings on Windows. To fix it we can move the setup.py into the root folder.

@yurymalkov
Copy link
Member

Thanks for the PR! Can you please add symbolic links to the old locations for the compatibility with older scripts?
Can you also modify travis to do CI for windows (e.g. following https://docs.travis-ci.com/user/languages/python/)?

@yurymalkov
Copy link
Member

Please add the symbolic link to setup.py. It seems a link for hnswlib is not needed - just altering a setup.py file. Something like this:

if "python_bindings" in os.path.basename(os.getcwd()): # compatibility when run in python_bindings
    source_files = ['./bindings.cpp']
    include_dirs = ['../hnswlib/']
else:
    source_files = ['./python_bindings/bindings.cpp']
    include_dirs = ['./hnswlib/']

@dyashuni
Copy link
Contributor Author

dyashuni commented Dec 9, 2020

Done, please check.

@yurymalkov
Copy link
Member

Looks good to me! Thank you!

@yurymalkov yurymalkov merged commit 6d3b29f into nmslib:develop Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants