Error when synchronizing the datawallet modification for a RequestedCredentialCacheEntry#893
Merged
tnotheis merged 5 commits intorelease/openid4vcfrom Dec 10, 2025
Conversation
jkoenig134
reviewed
Dec 9, 2025
jkoenig134
previously approved these changes
Dec 9, 2025
Contributor
jkoenig134
left a comment
jkoenig134
left a comment
There was a problem hiding this comment.
everything but the comment LGTM
…tawallet-modification-for-a-RequestedCredentialCacheEntry
…r-a-RequestedCredentialCacheEntry' of github.com:nmshd/runtime into error-when-synchronizing-the-datawallet-modification-for-a-RequestedCredentialCacheEntry
jkoenig134
approved these changes
Dec 10, 2025
tnotheis
deleted the
error-when-synchronizing-the-datawallet-modification-for-a-RequestedCredentialCacheEntry
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
Before my fix, the credential offer uri was used as the object identifier for the datawallet modification. This caused the following error on the Backbone, because it is too long:
And since we don't want personal data on the Backbone anyway, and a credential offer IS personal data, I introduced an artificial id for the RequestedCredentialCacheEntries.