Create Tokens with credential presentations#886
Merged
Magnus-Kuhn merged 30 commits intorelease/openid4vcfrom Jan 12, 2026
Merged
Create Tokens with credential presentations#886Magnus-Kuhn merged 30 commits intorelease/openid4vcfrom
Magnus-Kuhn merged 30 commits intorelease/openid4vcfrom
Conversation
Magnus-Kuhn
added
wip
Magnus-Kuhn
requested review from
Milena-Czierlinski,
jkoenig134 and
tnotheis
Magnus-Kuhn
removed
the
wip
jkoenig134
reviewed
Dec 8, 2025
jkoenig134
approved these changes
Dec 9, 2025
Magnus-Kuhn
added
the
wip
Contributor
Author
|
Putting this on hold because alternative approaches to presenting outside of OID4VP are being discussed |
Magnus-Kuhn
changed the title
Magnus-Kuhn
removed
the
wip
tnotheis
requested changes
Jan 12, 2026
packages/consumption/src/modules/openid4vc/OpenId4VcController.ts
Outdated
Show resolved
Hide resolved
erbenjak
reviewed
Jan 12, 2026
tnotheis
requested changes
Jan 12, 2026
packages/content/src/attributes/types/VerifiablePresentation.ts
Outdated
Show resolved
Hide resolved
tnotheis
previously approved these changes
Jan 12, 2026
Magnus-Kuhn
changed the title
tnotheis
approved these changes
Jan 12, 2026
| const attribute = await this.attributesController.getLocalAttribute(CoreId.from(request.attributeId)); | ||
| if (!(attribute?.content.value instanceof VerifiableCredential)) return Result.fail(RuntimeErrors.general.recordNotFound("Attribute with Verifiable Credential")); | ||
|
|
||
| const presentation = await this.openId4VcController.createPresentationForToken(attribute.content.value); |
Member
There was a problem hiding this comment.
@Magnus-Kuhn I know I'm late for the party, but can you please call the method on the controller the same as this use case? I remember the hassle of straightening the naming of our facade methods, use cases and controller methods in the first place and we should really make an effort to keep the code clean in order for others to understand it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
Allows to create a token with a credential presentation in order to present it as a QR code.