Enhance filters tests (kiegroup#34)

jbpm-wb-common/jbpm-wb-common-client/src/main/java/org/jbpm/workbench/common/client/filters/active/ActiveFiltersViewImpl.java

@@ -99,15 +99,19 @@ public void init() {
         });
 
         saveFilterPopover = jQueryPopover.wrap(this.saveFilter);
-        saveFilterPopoverView.setCancelCallback(() -> closeSaveFilter());
-        saveFilterPopoverView.setSaveCallback(name -> saveFilter(name));
+        setSaveFilterPopoverCallback();
         final PopoverOptions popoverOptions = new PopoverOptions();
         popoverOptions.setContent(e -> saveFilterPopoverView.getElement());
         saveFilterPopover.popover(popoverOptions);
         saveFilterPopover.addShowListener(() -> saveFilterPopoverView.onOpen());
         saveFilterPopover.addShownListener(() -> saveFilterPopoverView.onShow());
     }
 
+    protected void setSaveFilterPopoverCallback() {
+        saveFilterPopoverView.setCancelCallback(() -> closeSaveFilter());
+        saveFilterPopoverView.setSaveCallback(name -> saveFilter(name));
+    }
+
     @PreDestroy
     public void destroy() {
         saveFilterPopover.destroy();

jbpm-wb-common/jbpm-wb-common-client/src/main/java/org/jbpm/workbench/common/client/filters/saved/SavedFiltersPresenter.java

@@ -34,7 +34,7 @@
 import org.uberfire.workbench.model.menu.MenuFactory;
 import org.uberfire.workbench.model.menu.Menus;
 
-public abstract class SavedFiltersPresenter implements RestoreDefaultFiltersMenuBuilder.SupportsRestoreDefaultFilters {
+public class SavedFiltersPresenter implements RestoreDefaultFiltersMenuBuilder.SupportsRestoreDefaultFilters {
 
     private final Constants constants = Constants.INSTANCE;
 

jbpm-wb-common/jbpm-wb-common-client/src/test/java/org/jbpm/workbench/common/client/filters/active/ActiveFiltersViewImplTest.java

@@ -0,0 +1,71 @@
+/*
+ * Copyright 2018 Red Hat, Inc. and/or its affiliates.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.jbpm.workbench.common.client.filters.active;
+
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.Spy;
+import org.mockito.runners.MockitoJUnitRunner;
+import org.uberfire.client.views.pfly.widgets.Popover;
+import org.uberfire.mvp.Command;
+import org.uberfire.mvp.ParameterizedCommand;
+
+import static org.mockito.Matchers.any;
+import static org.mockito.Mockito.*;
+
+@RunWith(MockitoJUnitRunner.class)
+public class ActiveFiltersViewImplTest {
+
+    @Mock
+    Popover saveFilterPopover;
+
+    @Mock
+    SaveFilterPopoverView saveFilterPopoverView;
+
+    @InjectMocks
+    @Spy
+    ActiveFiltersViewImpl view;
+
+    @Test
+    public void testSaveFilterCallback() {
+        final String name = "filterName";
+        doAnswer(invocation -> {
+            ParameterizedCommand<String> callback = (ParameterizedCommand<String>) invocation.getArguments()[0];
+            callback.execute(name);
+            return null;
+        }).when(saveFilterPopoverView).setSaveCallback(any());
+
+        view.setSaveFilterPopoverCallback();
+
+        verify(view).saveFilter(name);
+    }
+
+    @Test
+    public void testCancelFilterCallback() {
+        doAnswer(invocation -> {
+            Command callback = (Command) invocation.getArguments()[0];
+            callback.execute();
+            return null;
+        }).when(saveFilterPopoverView).setCancelCallback(any());
+
+        view.setSaveFilterPopoverCallback();
+
+        verify(saveFilterPopover).hide();
+    }
+}

jbpm-wb-common/jbpm-wb-common-client/src/test/java/org/jbpm/workbench/common/client/filters/active/SaveFilterPopoverViewTest.java

@@ -0,0 +1,83 @@
+/*
+ * Copyright 2018 Red Hat, Inc. and/or its affiliates.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.jbpm.workbench.common.client.filters.active;
+
+import com.google.gwt.event.dom.client.KeyCodes;
+import com.google.gwt.event.dom.client.KeyDownEvent;
+import elemental2.dom.HTMLInputElement;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.runners.MockitoJUnitRunner;
+import org.uberfire.mvp.Command;
+import org.uberfire.mvp.ParameterizedCommand;
+
+import static org.mockito.Mockito.*;
+
+@RunWith(MockitoJUnitRunner.class)
+public class SaveFilterPopoverViewTest {
+
+    @Mock
+    HTMLInputElement filterName;
+
+    @InjectMocks
+    SaveFilterPopoverView popoverView;
+
+    @Test
+    public void testOnSaveCallback() {
+        final String value = "value";
+        filterName.value = value;
+
+        final ParameterizedCommand<String> callback = mock(ParameterizedCommand.class);
+
+        popoverView.setSaveCallback(callback);
+
+        popoverView.onSave(null);
+
+        verify(callback).execute(value);
+    }
+
+    @Test
+    public void testOnKeyPressEvent() {
+        final String value = "value";
+        filterName.value = value;
+
+        final ParameterizedCommand<String> callback = mock(ParameterizedCommand.class);
+
+        popoverView.setSaveCallback(callback);
+
+        final KeyDownEvent event = mock(KeyDownEvent.class);
+        when(event.getNativeKeyCode()).thenReturn(KeyCodes.KEY_ENTER,
+                                                  KeyCodes.KEY_A);
+        popoverView.onKeyPressEvent(event);
+        popoverView.onKeyPressEvent(event);
+
+        verify(callback).execute(value);
+    }
+
+    @Test
+    public void testCancelCallback() {
+        final Command callback = mock(Command.class);
+
+        popoverView.setCancelCallback(callback);
+
+        popoverView.onCancel(null);
+
+        verify(callback).execute();
+    }
+}

jbpm-wb-common/jbpm-wb-common-client/src/test/java/org/jbpm/workbench/common/client/filters/basic/AbstractBasicFiltersPresenterTest.java

@@ -0,0 +1,117 @@
+/*
+ * Copyright 2018 Red Hat, Inc. and/or its affiliates.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.jbpm.workbench.common.client.filters.basic;
+
+import java.util.function.Consumer;
+import javax.enterprise.event.Event;
+
+import org.jbpm.workbench.common.client.filters.saved.SavedFilterSelectedEvent;
+import org.jbpm.workbench.df.client.filter.FilterEditorPopup;
+import org.jbpm.workbench.df.client.filter.FilterSettings;
+import org.jbpm.workbench.df.client.filter.FilterSettingsManager;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.ArgumentCaptor;
+import org.mockito.Mock;
+import org.mockito.Spy;
+import org.uberfire.mocks.EventSourceMock;
+import org.uberfire.mvp.Command;
+
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.eq;
+import static org.mockito.Mockito.*;
+
+public abstract class AbstractBasicFiltersPresenterTest {
+
+    @Mock
+    BasicFiltersView view;
+
+    @Mock
+    FilterEditorPopup filterEditorPopup;
+
+    @Mock
+    FilterSettingsManager filterSettingsManager;
+
+    @Spy
+    Event<BasicFilterAddEvent> activeFilters = new EventSourceMock<>();
+
+    @Spy
+    Event<SavedFilterSelectedEvent> savedFilterSelectedEvent = new EventSourceMock<>();
+
+    public abstract BasicFiltersPresenter getPresenter();
+
+    public BasicFiltersView getView() {
+        return view;
+    }
+
+    @Before
+    public void init() {
+        doNothing().when(savedFilterSelectedEvent).fire(any(SavedFilterSelectedEvent.class));
+        doNothing().when(activeFilters).fire(any(BasicFilterAddEvent.class));
+    }
+
+    @Test
+    public void testSaveAdvancedFiltersCallback() {
+        doAnswer(invocation -> {
+            Command callback = (Command) invocation.getArguments()[0];
+            callback.execute();
+            return null;
+        }).when(view).setAdvancedFiltersCallback(any());
+
+        getPresenter().init();
+
+        verify(filterEditorPopup).setTitle(any());
+        ArgumentCaptor<Consumer> captor = ArgumentCaptor.forClass(Consumer.class);
+        verify(filterEditorPopup).show(any(),
+                                       captor.capture());
+        final FilterSettings filterSettings = new FilterSettings();
+        captor.getValue().accept(filterSettings);
+
+        verify(filterSettingsManager).saveFilterIntoPreferences(eq(filterSettings),
+                                                                captor.capture());
+        captor.getValue().accept(true);
+
+        verify(filterEditorPopup).hide();
+        verify(savedFilterSelectedEvent).fire(any());
+    }
+
+    @Test
+    public void testSaveInvalidAdvancedFiltersCallback() {
+        doAnswer(invocation -> {
+            Command callback = (Command) invocation.getArguments()[0];
+            callback.execute();
+            return null;
+        }).when(view).setAdvancedFiltersCallback(any());
+
+        getPresenter().init();
+
+        verify(filterEditorPopup).setTitle(any());
+        ArgumentCaptor<Consumer> captor = ArgumentCaptor.forClass(Consumer.class);
+        verify(filterEditorPopup).show(any(),
+                                       captor.capture());
+        final FilterSettings filterSettings = new FilterSettings();
+        captor.getValue().accept(filterSettings);
+
+        verify(filterSettingsManager).saveFilterIntoPreferences(eq(filterSettings),
+                                                                captor.capture());
+        captor.getValue().accept(false);
+
+        verify(filterEditorPopup).setTableNameError(any());
+    }
+
+    public abstract void testLoadFilters();
+}

jbpm-wb-common/jbpm-wb-common-client/src/test/java/org/jbpm/workbench/common/client/filters/basic/ActiveFiltersImplTest.java

@@ -0,0 +1,90 @@
+/*
+ * Copyright 2018 Red Hat, Inc. and/or its affiliates.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.jbpm.workbench.common.client.filters.basic;
+
+import org.jbpm.workbench.common.client.filters.active.ActiveFilterItem;
+import org.jbpm.workbench.common.client.filters.active.ActiveFiltersImpl;
+import org.jbpm.workbench.common.client.filters.active.ActiveFiltersView;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.runners.MockitoJUnitRunner;
+import org.uberfire.mvp.ParameterizedCommand;
+
+import static org.mockito.Matchers.any;
+import static org.mockito.Mockito.*;
+
+@RunWith(MockitoJUnitRunner.class)
+public class ActiveFiltersImplTest {
+
+    @Mock
+    ActiveFiltersView view;
+
+    @InjectMocks
+    ActiveFiltersImpl activeFilters;
+
+    @Test
+    public void testRemoveAllActiveFilters() {
+        activeFilters.removeAllActiveFilters();
+
+        verify(view).removeAllActiveFilters();
+    }
+
+    @Test
+    public void testAddActiveFilter() {
+        final ActiveFilterItem<Object> filter = new ActiveFilterItem<>();
+        activeFilters.addActiveFilter(filter);
+
+        verify(view).addActiveFilter(filter);
+    }
+
+    @Test
+    public void testSaveFilterCallbackNull() {
+        doAnswer(invocation -> {
+            ParameterizedCommand<String> callback = (ParameterizedCommand<String>) invocation.getArguments()[0];
+            callback.execute(null);
+            return null;
+        }).when(view).setSaveFilterCallback(any());
+
+        activeFilters.setSaveFilterCallback((name, callback) -> callback.accept(null));
+        activeFilters.init();
+
+        verify(view).setSaveFilterCallback(any());
+        verify(view).closeSaveFilter();
+        verify(view,
+               never()).setSaveFilterErrorMessage(any());
+    }
+
+    @Test
+    public void testSaveFilterCallbackError() {
+        final String message = "error";
+        doAnswer(invocation -> {
+            ParameterizedCommand<String> callback = (ParameterizedCommand<String>) invocation.getArguments()[0];
+            callback.execute(null);
+            return null;
+        }).when(view).setSaveFilterCallback(any());
+
+        activeFilters.setSaveFilterCallback((name, callback) -> callback.accept(message));
+        activeFilters.init();
+
+        verify(view).setSaveFilterCallback(any());
+        verify(view,
+               never()).closeSaveFilter();
+        verify(view).setSaveFilterErrorMessage(message);
+    }
+}