Skip to content

Commit

Permalink
Clean unused services replaced by remote ones - tasks. (kiegroup#23)
Browse files Browse the repository at this point in the history
  • Loading branch information
@nmirasch @mswiderski
nmirasch authored and mswiderski committed Jun 23, 2016
1 parent e17298e commit 5178a55
Show file tree
Hide file tree
Showing 7 changed files with 4 additions and 145 deletions.
24 changes: 0 additions & 24 deletions ...g-human-tasks-api/src/main/java/org/jbpm/console/ng/ht/service/TaskOperationsService.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,36 +16,12 @@

package org.jbpm.console.ng.ht.service;

import java.util.Date;
import java.util.List;
import java.util.Map;
import java.util.Set;

import org.jboss.errai.bus.server.annotations.Remote;
import org.jbpm.console.ng.ht.model.TaskAssignmentSummary;
import org.jbpm.console.ng.ht.model.TaskSummary;

@Remote
public interface TaskOperationsService {

public long addQuickTask(
final String taskName,
int priority,
Date dueDate, final List<String> users, List<String> groups, String identity, boolean start,
boolean claim,String taskFormName, String deploymentId, Long processInstanceId);

public void updateTask(long taskId, int priority, List<String> taskDescription, Date dueDate);

TaskSummary getTaskDetails(long taskId);

long saveContent(long taskId, Map<String, Object> values);

boolean existInDatabase(long taskId);

TaskAssignmentSummary getTaskAssignmentDetails(String serverTemplateId, String containerId, long taskId);

void executeReminderForTask(long taskId,String fromUser);

Boolean allowDelegate(long taskId, String userId, Set<String> groups);

}
61 changes: 0 additions & 61 deletions ...ackend/src/main/java/org/jbpm/console/ng/ht/backend/server/TaskOperationsServiceImpl.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,79 +16,18 @@

package org.jbpm.console.ng.ht.backend.server;

import java.util.Date;
import java.util.List;
import java.util.Map;
import java.util.Set;
import javax.enterprise.context.ApplicationScoped;

import org.jboss.errai.bus.server.annotations.Service;
import org.jbpm.console.ng.ht.model.TaskAssignmentSummary;
import org.jbpm.console.ng.ht.model.TaskSummary;
import org.jbpm.console.ng.ht.service.TaskOperationsService;

@Service
@ApplicationScoped
public class TaskOperationsServiceImpl implements TaskOperationsService {


@Override
public long addQuickTask(
final String taskName,
int priority,
Date dueDate, final List<String> users, List<String> groups, String identity, boolean start,
boolean claim,String taskformName,String deploymentId, Long processInstanceId){


return -1;
}

@Override
public void updateTask(long taskId, int priority, List<String> taskDescription,
Date dueDate) {

}


@Override
public TaskSummary getTaskDetails(long taskId) {

return null;
}

@Override
public long saveContent(long taskId, Map<String, Object> values) {
return -1;
}

@Override
public boolean existInDatabase(long taskId) {
return false;
}

@Override
public TaskAssignmentSummary getTaskAssignmentDetails(String serverTemplateId, String containerId, long taskId) {

return null;
}

@Override
public void executeReminderForTask(long taskId,String fromUser) {

}

/**
* Checks if the user is allowed to delegate the given task
*
* @param taskId
* @param userId
* @param groups
* @return
*/
@Override
public Boolean allowDelegate(long taskId, final String userId, final Set<String> groups) {

return false;
}

}
4 changes: 3 additions & 1 deletion ...t/src/main/java/org/jbpm/console/ng/ht/client/editors/quicknewtask/QuickNewTaskPopup.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,8 @@ public void addTask( final List<String> users,
}
}

/*
taskOperationsService.call( new RemoteCallback<Long>() {
@Override
public void callback( Long taskId ) {
Expand All @@ -479,7 +481,7 @@ public boolean error( Message message,
}
} ).addQuickTask( taskName, priority, due, users, groups, identity.getIdentifier(), start, claim,
taskFormName, deploymentId, processInstanceId );

*/
}

private void refreshNewTask( Long taskId,
Expand Down
3 changes: 1 addition & 2 deletions ...rc/main/java/org/jbpm/console/ng/ht/client/editors/taskcomments/TaskCommentsViewImpl.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import com.google.gwt.cell.client.HasCell;
import com.google.gwt.cell.client.TextCell;
import com.google.gwt.core.client.GWT;
import com.google.gwt.dom.client.Style;
import com.google.gwt.event.dom.client.ClickEvent;
import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
import com.google.gwt.user.cellview.client.Column;
Expand Down Expand Up @@ -146,7 +145,7 @@ public String getValue( CommentSummary c ) {
addedByColumn.setSortable( false );
addedByColumn.setDataStoreName(COL_ADDEDBY);
commentsListGrid.addColumn( addedByColumn, constants.Added_By() );
commentsListGrid.setColumnWidth( addedByColumn, 100, Style.Unit.PX );


// date
Column<CommentSummary, String> addedAtColumn = new Column<CommentSummary, String>( new TextCell() ) {
Expand Down
4 changes: 0 additions & 4 deletions .../jbpm/console/ng/ht/client/editors/taskslist/grid/dash/DataSetTasksListGridPresenter.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,12 @@
package org.jbpm.console.ng.ht.client.editors.taskslist.grid.dash;

import javax.enterprise.context.Dependent;
import javax.inject.Inject;

import org.jbpm.console.ng.gc.client.menu.RestoreDefaultFiltersMenuBuilder;
import org.jbpm.console.ng.ht.client.editors.quicknewtask.QuickNewTaskPopup;
import org.jbpm.console.ng.ht.client.editors.taskslist.grid.AbstractTasksListGridPresenter;
import org.jbpm.console.ng.ht.client.i18n.Constants;
import org.uberfire.client.annotations.WorkbenchMenu;
import org.uberfire.client.annotations.WorkbenchScreen;
import org.uberfire.ext.widgets.common.client.menu.RefreshMenuBuilder;
import org.uberfire.mvp.Command;
import org.uberfire.workbench.model.menu.MenuFactory;
import org.uberfire.workbench.model.menu.Menus;

Expand Down
36 changes: 0 additions & 36 deletions ...ole-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/i18n/Constants.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,6 @@ public interface Constants extends Messages {

String Actions();

String No_Parent();

String User();

String Process_Id();
Expand Down Expand Up @@ -137,20 +135,14 @@ public interface Constants extends Messages {

String Refresh();

String Tasks_Refreshed();

String Add_User();

String Add_Group();

String Remove_User();

String Remove_Group();

String Assignments();

String Auto_Assign_To_Me();

String Created_On();

String DeploymentId();
Expand All @@ -159,10 +151,6 @@ public interface Constants extends Messages {

String ParentId();

String Text_Require();

String UserOrGroup();

String Forward();

String Delegate();
Expand All @@ -171,12 +159,6 @@ public interface Constants extends Messages {

String No_Potential_Owners();

String Add_TypeRole();

String Type_Role();

String Parent_Group();

String Save();

String Delete();
Expand All @@ -189,10 +171,6 @@ public interface Constants extends Messages {

String Provide_User_Or_Group();

String Show_Details();

String Hide_Details();

String Task_Admin();

String FilterTaskAdmin();
Expand Down Expand Up @@ -239,26 +217,14 @@ public interface Constants extends Messages {

String InProgress();

String Suspended();

String Failed();

String Error();

String Exited();

String Obsolete();

String Completed();

String TaskRole();

String Initiator();

String Stakeholder();

String Potential_Owner();

String Administrator();

String Task_Form();
Expand All @@ -273,8 +239,6 @@ public interface Constants extends Messages {

String UnexpectedError(String errorMessage);

String NotFoundDataSetWithId();

String TaskReleased(String taskId);

String TaskClaimed(String taskId);
Expand Down
17 changes: 0 additions & 17 deletions ...n-tasks-client/src/main/resources/org/jbpm/console/ng/ht/client/i18n/Constants.properties
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ Work=Work
Start=Start
Details=Details
Actions=Actions
No_Parent=No Parent
User=User
Process_Id=Process Id
Process_Name=Process Name
Expand All @@ -53,32 +52,22 @@ Form=Form
Advanced=Advanced
Basic=Basic
Refresh=Refresh
Tasks_Refreshed=Tasks Refreshed
Add_User=Add User
Add_Group=Add Group
Remove_User=Remove User
Remove_Group=Remove Group
Assignments=Assignments
Auto_Assign_To_Me=Auto Assign To Me
Created_On=Created On
Text_Require=This text is required
UserOrGroup=User or Group
Forward=Forward
Delegate=Delegate
Potential_Owners=Potential Owners
No_Potential_Owners=There are no Potential Owners
No_Actual_Owner=There are no Actual Owners
Add_TypeRole=Add Type Role
Type_Role=Type Role
Parent_Group=Parent Group
Save=Save
Delete=Delete
Calendar=Calendar
Logs=Logs
Task_Log=Task Log
Provide_User_Or_Group=You should provide at least a user or a group
Show_Details=Show Details
Hide_Details=Hide Details
Task_Admin=Admin
FilterTaskAdmin=Filter Admin
Loading=Loading...
Expand All @@ -94,24 +83,18 @@ Created=Created
Ready=Ready
Reserved=Reserved
InProgress=InProgress
Suspended=Suspended
Failed=Failed
Error=Error
Exited=Exited
Obsolete=Obsolete
Completed=Completed
TaskRole=Task role
Initiator=Initiator
Stakeholder=Stakeholder
Potential_Owner=Potential_Owner
Administrator=Administrator
Task_Form=Form
Task_Form_Name=Task form name
Task_Form_DeploymentId=Task form deploymentId
New_FilteredList=New filtered list
Administrators=Administrators
UnexpectedError=Unexpected error occurred\: {0}
NotFoundDataSetWithId=Not Found dataset with id
TaskReleased=Task with id {0} released
TaskClaimed=Task with id {0} claimed
ActivationTime=Activation Time
Expand Down

0 comments on commit 5178a55

Please sign in to comment.