Skip to content

Comments

revise recr_dist output to show both sexes#612

Merged
Rick-Methot-NOAA merged 3 commits intomainfrom
611-revise-recr_dist-output-to-work-better-for-models-without-5050-sex-ratio-at-recruitment
Aug 28, 2024
Merged

revise recr_dist output to show both sexes#612
Rick-Methot-NOAA merged 3 commits intomainfrom
611-revise-recr_dist-output-to-work-better-for-models-without-5050-sex-ratio-at-recruitment

Conversation

@Rick-Methot-NOAA
Copy link
Collaborator

Concisely describe what has been changed/addressed in the pull request.

revise recruitment distribution output to show males and females. This is helpful for hermaphroditism applications

What tests have been done?

see test file linked in the issue.
revised output is visible in the issue and shows the desired feature

Is there an input change for users to Stock Synthesis?

[x] No, there was no input change.

Copy link
Contributor

@iantaylor-NOAA iantaylor-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the quick fix @Rick-Methot-NOAA.

In hindsight it's easy enough to compute the male distribution as 1 - females, but I think having all the output there makes things more transparent and easier to access.

I'll finish modifying r4ss to work with this revised output tomorrow (mostly just requires looping over sexes before making the figure).

@iantaylor-NOAA
Copy link
Contributor

The test-r4ss-with-ss3 github action is failing here in modifications I made to the SSplotRecrdist() plot to take advantage of the output for males and females. However, I can't replicate the issue. The two models that are causing problems, Simple_with_DM_sizefreq and two_morph_seas_areas, work fine when running with the SS3 exe from this 611... branch and the main branch of r4ss on my local computer. Trying to trap for incorrectly specified values in the r4ss function didn't work either and it's hard to debug without replicating the problem.

I tried running a github codespace to debug further but am having trouble getting that running. I will be in Sea Safety Training for the next few days but can try again on Monday. Hopefully the delay isn't a big deal as I don't think the changes in this PR interact with other work.

@e-perl-NOAA if you feel like trying to debug via codespaces or any other method before I get back to it, feel free.

@e-perl-NOAA
Copy link
Collaborator

The r4ss issue is resolved so this should be good to go now.

@Rick-Methot-NOAA Rick-Methot-NOAA merged commit 369a23a into main Aug 28, 2024
@Rick-Methot-NOAA Rick-Methot-NOAA deleted the 611-revise-recr_dist-output-to-work-better-for-models-without-5050-sex-ratio-at-recruitment branch August 28, 2024 14:46
@github-actions
Copy link

Here are the successful executable builds from your PR:
ss3-ubuntu-latest
ss3-macos-12
ss3-windows-latest
ss3-macos-latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

revise RECR_DIST output to work better for models without 50/50 sex ratio at recruitment?

3 participants