revise recr_dist output to show both sexes#612
Conversation
iantaylor-NOAA
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the quick fix @Rick-Methot-NOAA.
In hindsight it's easy enough to compute the male distribution as 1 - females, but I think having all the output there makes things more transparent and easier to access.
I'll finish modifying r4ss to work with this revised output tomorrow (mostly just requires looping over sexes before making the figure).
|
The test-r4ss-with-ss3 github action is failing here in modifications I made to the I tried running a github codespace to debug further but am having trouble getting that running. I will be in Sea Safety Training for the next few days but can try again on Monday. Hopefully the delay isn't a big deal as I don't think the changes in this PR interact with other work. @e-perl-NOAA if you feel like trying to debug via codespaces or any other method before I get back to it, feel free. |
|
The r4ss issue is resolved so this should be good to go now. |
|
Here are the successful executable builds from your PR: |
Concisely describe what has been changed/addressed in the pull request.
revise recruitment distribution output to show males and females. This is helpful for hermaphroditism applications
What tests have been done?
see test file linked in the issue.
revised output is visible in the issue and shows the desired feature
Is there an input change for users to Stock Synthesis?
[x] No, there was no input change.