Conversation
iantaylor-NOAA
approved these changes
Feb 21, 2024
Contributor
iantaylor-NOAA
left a comment
iantaylor-NOAA
left a comment
There was a problem hiding this comment.
Changes look good to me.
It might be worth waiting until the workflows are sorted out before merging to confirm that the tests pass.
* update makefile * make build-warnings workflow robust to mismatched warnings * small change to contributing.md * add make_ss_warn.bat --------- Co-authored-by: e-gugliotti-NOAA <elizabeth.gugliotti@noaa.gov> Co-authored-by: Ian Taylor <ian.taylor@noaa.gov>
Collaborator
Author
|
@e-perl-NOAA help please. |
Collaborator
|
Probably has to deal with the merge conflicts with the recent push of the makefile updates. Will rebase tomorrow morning. |
Collaborator
|
@Rick-Methot-NOAA this should be good to merge now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves issue #569
Concisely describe what has been changed/addressed in the pull request.
add output of discard_at_age for forecast years
What tests have been done?
visual exam of report.sso shows that discard_at-age now appears for forecast years