Skip to content

Comments

Fixes ADMB version number#374

Merged
Rick-Methot-NOAA merged 1 commit intomainfrom
373-update-admb-version-info
Sep 30, 2022
Merged

Fixes ADMB version number#374
Rick-Methot-NOAA merged 1 commit intomainfrom
373-update-admb-version-info

Conversation

@kellijohnson-NOAA
Copy link
Contributor

Concisely (20 words or less) describe the issue

Updates the version number of ADMB to 13.0, using a hard-coded value.

Please Link issue(s)

Resolves #373

If not, please add documentation before submitting the Pull Request.

  • I have documented any new code added (or no new code was added)

is there an input change for users to Stock Synthesis?

  • Yes, there was an input change

If so, please provide an example of the new inputs needed.

[New example stock synthesis input goes here]

Check which is true. This PR requires:

  • no further changes to r4ss
  • no further changes to the manual
  • no further changes to SSI (the SS3 GUI)
  • no further changes to the stock synthesis change log (new features, bug reports)

Describe any changes in r4ss/SS3 manual/SSI that are needed (if not checked):

If changes are needed in the change log, please fill in the table here:

Action Topics Type
[fix, new, or revise] [e.g., biology. Use issue label options.] [input, output, and/or calc, or ALL]

Additional information (optional):

Still using a hard-coded number.
Part of #373
@kellijohnson-NOAA kellijohnson-NOAA added this to the 3.30.20 milestone Sep 30, 2022
@kellijohnson-NOAA kellijohnson-NOAA linked an issue Sep 30, 2022 that may be closed by this pull request
@Rick-Methot-NOAA Rick-Methot-NOAA self-requested a review September 30, 2022 15:34
Copy link
Collaborator

@Rick-Methot-NOAA Rick-Methot-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@Rick-Methot-NOAA Rick-Methot-NOAA merged commit e229a3f into main Sep 30, 2022
@iantaylor-NOAA
Copy link
Contributor

Oops, good catch. I should have done this with the other changes to move to ADMB 13.0. We can do it all again for ADMB 13.1 in the next release.

@Rick-Methot-NOAA Rick-Methot-NOAA deleted the 373-update-admb-version-info branch September 30, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need to update ADMB version info

3 participants